Skip to content

Commit 7c8e586

Browse files
committed
BC
1 parent a1d407e commit 7c8e586

File tree

8 files changed

+56
-26
lines changed

8 files changed

+56
-26
lines changed

src/Type/Doctrine/CreateQueryDynamicReturnTypeExtension.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,11 @@
2222
final class CreateQueryDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension
2323
{
2424

25-
private ObjectMetadataResolver $objectMetadataResolver;
25+
/** @var ObjectMetadataResolver */
26+
private $objectMetadataResolver;
2627

27-
private DescriptorRegistry $descriptorRegistry;
28+
/** @var DescriptorRegistry */
29+
private $descriptorRegistry;
2830

2931
public function __construct(ObjectMetadataResolver $objectMetadataResolver, DescriptorRegistry $descriptorRegistry)
3032
{
@@ -78,15 +80,15 @@ public function getTypeFromMethodCall(
7880

7981
return new GenericObjectType(
8082
Query::class,
81-
[$typeMapping->getResultType()],
83+
[$typeMapping->getResultType()]
8284
);
8385
}
8486

8587
private function fallbackType(): GenericObjectType
8688
{
8789
return new GenericObjectType(
8890
Query::class,
89-
[new MixedType(true)],
91+
[new MixedType(true)]
9092
);
9193
}
9294

src/Type/Doctrine/Query/QueryResultDynamicReturnTypeExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public function getTypeFromMethodCall(
8181

8282
return new ArrayType(
8383
new IntegerType(),
84-
$resultType,
84+
$resultType
8585
);
8686
}
8787

src/Type/Doctrine/Query/QueryResultTypeMapping.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,14 @@
1111
final class QueryResultTypeMapping
1212
{
1313

14-
private bool $selectQuery = false;
14+
/** @var bool */
15+
private $selectQuery = false;
1516

1617
/** @var array<array-key,Type> */
17-
private array $entities = [];
18+
private $entities = [];
1819

1920
/** @var array<array-key,Type> */
20-
private array $scalars = [];
21+
private $scalars = [];
2122

2223
public function setSelectQuery(): void
2324
{

src/Type/Doctrine/Query/QueryResultTypeWalker.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,11 @@ class QueryResultTypeWalker extends SqlWalker
7979
/** @var array<array-key,bool> */
8080
private $nullableQueryComponents;
8181

82-
private QueryResultTypeMapping $typeMapping;
82+
/** @var QueryResultTypeMapping */
83+
private $typeMapping;
8384

84-
private DescriptorRegistry $descriptorRegistry;
85+
/** @var DescriptorRegistry */
86+
private $descriptorRegistry;
8587

8688
private bool $isAggregated;
8789

@@ -125,7 +127,7 @@ public function __construct($query, $parserResult, array $queryComponents)
125127
'Expected the query hint %s to contain a %s, but got a %s',
126128
self::HINT_TYPE_MAPPING,
127129
QueryResultTypeMapping::class,
128-
is_object($typeMapping) ? get_class($typeMapping) : gettype($typeMapping),
130+
is_object($typeMapping) ? get_class($typeMapping) : gettype($typeMapping)
129131
));
130132
}
131133

@@ -138,7 +140,7 @@ public function __construct($query, $parserResult, array $queryComponents)
138140
'Expected the query hint %s to contain a %s, but got a %s',
139141
self::HINT_DESCRIPTOR_REGISTRY,
140142
DescriptorRegistry::class,
141-
is_object($descriptorRegistry) ? get_class($descriptorRegistry) : gettype($descriptorRegistry),
143+
is_object($descriptorRegistry) ? get_class($descriptorRegistry) : gettype($descriptorRegistry)
142144
));
143145
}
144146

@@ -751,7 +753,7 @@ public function walkAggregateExpression($aggExpression)
751753
case 'AVG':
752754
case 'SUM':
753755
$type = $this->unmarshalType(
754-
$aggExpression->pathExpression->dispatch($this),
756+
$aggExpression->pathExpression->dispatch($this)
755757
);
756758

757759
return $this->marshalType(TypeCombinator::addNull($type));

tests/Type/Doctrine/Query/QueryResultTypeWalkerTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,11 @@
2727
final class QueryResultTypeWalkerTest extends PHPStanTestCase
2828
{
2929

30-
private EntityManagerInterface $em;
30+
/** @var EntityManagerInterface */
31+
private $em;
3132

32-
private DescriptorRegistry $descriptorRegistry;
33+
/** @var DescriptorRegistry */
34+
private $descriptorRegistry;
3335

3436
public static function getAdditionalConfigFiles(): array
3537
{

tests/Type/Doctrine/Query/data/QueryResult/Entities/Many.php

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,37 +16,51 @@ class Many
1616
/**
1717
* @Column(type="bigint")
1818
* @Id
19+
*
20+
* @var string
1921
*/
20-
public int $id;
22+
public $id;
2123

2224
/**
2325
* @Column(type="integer")
26+
*
27+
* @var int
2428
*/
2529
public int $intColumn;
2630

2731
/**
2832
* @Column(type="string")
33+
*
34+
* @var string
2935
*/
3036
public string $stringColumn;
3137

3238
/**
3339
* @Column(type="string", nullable=true)
40+
*
41+
* @var string|null
3442
*/
35-
public ?string $stringNullColumn;
43+
public $stringNullColumn;
3644

3745
/**
3846
* @Column(type="datetime")
47+
*
48+
* @var \DateTime
3949
*/
40-
public \DateTime $datetimeColumn;
50+
public $datetimeColumn;
4151

4252
/**
4353
* @Column(type="datetime_immutable")
54+
*
55+
* @var \DateTimeImmutable
4456
*/
45-
public \DateTimeImmutable $datetimeImmutableColumn;
57+
public $datetimeImmutableColumn;
4658

4759
/**
4860
* @ManyToOne(targetEntity="QueryResult\Entities\One", inversedBy="one")
4961
* @JoinColumn(nullable=true)
62+
*
63+
* @var One|null
5064
*/
51-
public ?One $one;
65+
public $one;
5266
}

tests/Type/Doctrine/Query/data/QueryResult/Entities/ManyId.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44

55
class ManyId
66
{
7-
public string $id;
7+
/** @var string */
8+
public $id;
89

910
public function __construct(string $id)
1011
{

tests/Type/Doctrine/Query/data/QueryResult/Entities/One.php

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,30 +18,38 @@ class One
1818
/**
1919
* @Column(type="bitint")
2020
* @Id
21+
*
22+
* @var string
2123
*/
22-
public int $id;
24+
public $id;
2325

2426
/**
2527
* @Column(type="integer")
2628
* @Id
29+
*
30+
* @var int
2731
*/
28-
public int $intColumn;
32+
public $intColumn;
2933

3034
/**
3135
* @Column(type="string")
36+
*
37+
* @var string
3238
*/
33-
public string $stringColumn;
39+
public $stringColumn;
3440

3541
/**
3642
* @Column(type="string", nullable=true)
43+
*
44+
* @var string|null
3745
*/
38-
public ?string $stringNullColumn;
46+
public $stringNullColumn;
3947

4048
/**
4149
* @OneToMany(targetEntity="QueryResult\Entities\Many", mappedBy="one")
4250
* @JoinColumn(nullable=true)
4351
*
4452
* @var Collection<int,Many>
4553
*/
46-
public Collection $manies;
54+
public $manies;
4755
}

0 commit comments

Comments
 (0)