showing refresh interval as part of UI and checks to prevent errorneous setting from being saved.

Author: arpitbbhayani

src/l10n/locale/de.ts

@@ -19,7 +19,7 @@ export default {
     "Reset to default": "Zurücksetzen",
     'HackerNews Settings': 'Wörterbuch Einstellungen',
     'Refresh Interval': 'Refresh Interval',
-    'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be considered as 60 seconds.': 'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be considered as 60 seconds.',
+    'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be reverted to 60 seconds.': 'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be reverted to 60 seconds.',
     'Language': 'Sprache',
     'The Language the Plugin will use to search for Definitions and Pronunciations.': 'Die Sprache, welche von dieser Erweiterung verwendet wird, um nach Definitionen zu suchen.',
     'Synonym Suggestions': 'Synonym Vorschläge',

src/l10n/locale/en.ts

@@ -19,7 +19,7 @@ export default {
     "Reset to default": "Reset to default",
     'HackerNews Settings': 'HackerNews Settings',
     'Refresh Interval': 'Refresh Interval',
-    'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be considered as 60 seconds.': 'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be considered as 60 seconds.',
+    'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be reverted to 60 seconds.': 'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be reverted to 60 seconds.',
     'Language': 'Language',
     'The Language the Plugin will use to search for Definitions and Pronunciations.': 'The Language the Plugin will use to search for Definitions and Pronunciations.',
     'Synonym Suggestions': 'Synonym Suggestions',

src/l10n/locale/zh-cn.ts

@@ -17,7 +17,7 @@ export default {
     //settingsTab.ts
     'HackerNews Settings': '词典设置',
     'Refresh Interval': 'Refresh Interval',
-    'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be considered as 60 seconds.': 'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be considered as 60 seconds.',
+    'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be reverted to 60 seconds.': 'The time interval in seconds after which the next top story will be fetched. Default and invalid values will be reverted to 60 seconds.',
     'Language': '语言',
     'The Language the Plugin will use to search for Definitions and Pronunciations.': '插件会根据该语言来搜索语义以及发音',
     'Synonym Suggestions': '同义词建议',

src/ui/dictionary/dictionaryView.svelte

@@ -10,6 +10,7 @@
   import t from "src/l10n/helpers";
 
   export let manager: APIManager;
+  export let refreshInterval: string;
 
   export let query: string = "";
   let promise: Promise<DictionaryWord>;
@@ -56,6 +57,9 @@
         <p class="hn-read">
           <a href="{ dataHN.url }" target="_blank">Read more →</a>
         </p>
+        <p class="hn-meta">
+          Refreshes every { refreshInterval } seconds.
+        </p>
       </div>
     </div>
   {/if}
@@ -73,6 +77,11 @@
     margin-top: 0.5em;
   }
 
+  .hn-meta {
+    font-size: 0.7em;
+    color: #aaa;
+  }
+
   .results {
     display: flex;
     flex-wrap: wrap;

src/ui/dictionary/dictionaryView.ts

@@ -47,6 +47,9 @@ export default class DictionaryView extends ItemView {
                 localDictionary: this.plugin.localDictionary,
             }
         });
+        this._view.$set({
+            refreshInterval: this.plugin.settings.defaultRefreshInterval,
+        });
         addEventListener('dictionary-open-language-switcher', () => {
             new LanguageChooser(this.app, this.plugin).open();
         });

src/ui/settings/settingsTab.ts

@@ -22,12 +22,14 @@ export default class SettingsTab extends PluginSettingTab {
 
         new Setting(containerEl)
             .setName(t('Refresh Interval'))
-            .setDesc(t('The time interval in seconds after which the next top story will be fetched. Default and invalid values will be considered as 60 seconds.'))
+            .setDesc(t('The time interval in seconds after which the next top story will be fetched. Default and invalid values will be reverted to 60 seconds.'))
             .addText(text => text
                 .setPlaceholder('60')
                 .setValue(plugin.settings.defaultRefreshInterval)
                 .onChange(async (value) => {
-                    plugin.settings.defaultRefreshInterval = value;
+                    let refreshInterval = parseInt(value)
+                    if (Number.isNaN(refreshInterval) || refreshInterval <= 0) { refreshInterval = 60 }
+                    plugin.settings.defaultRefreshInterval = `${refreshInterval}`;
                     await this.save();
                 }));
         new Setting(containerEl)