[issue-1282]add org.hamcrest archive to bld and re-enbabled commented code

Author: rsearls

kubernetes/istio/istio/src/main/java/org/arquillian/cube/istio/impl/IstioAssistant.java

@@ -124,7 +124,6 @@ public void await(final URL url, Function<Response, Boolean> checker) {
     }
 
     public void await(final Request request, Function<Response, Boolean> checker) {
-        /** rls TODO https://github.com/arquillian/arquillian-cube/issues/1282
         Awaitility.await()
             .atMost(30, TimeUnit.SECONDS)
             .ignoreExceptions()
@@ -133,6 +132,5 @@ public void await(final Request request, Function<Response, Boolean> checker) {
                     return checker.apply(response);
                 }
             });
-        **/
     }
 }

kubernetes/kubernetes/pom.xml

@@ -123,6 +123,10 @@
       <groupId>org.jboss.arquillian.config</groupId>
       <artifactId>arquillian-config-impl-base</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.hamcrest</groupId>
+      <artifactId>hamcrest</artifactId>
+    </dependency>
   </dependencies>
 
   <build>

kubernetes/kubernetes/src/main/java/org/arquillian/cube/kubernetes/impl/KubernetesAssistant.java

@@ -409,15 +409,13 @@ public void awaitApplicationReadinessOrFail() {
      * @param applicationName name of the application to wait for pods readiness
      */
     public void awaitApplicationReadinessOrFail(final String applicationName) {
-        /** rls TODO uncomment code and resolve compile issue. https://github.com/arquillian/arquillian-cube/issues/1282
         await().atMost(5, TimeUnit.MINUTES).until(() -> {
                 return client
                     .replicationControllers()
                     .inNamespace(this.namespace)
                     .withName(applicationName).isReady();
             }
         );
-        **/
     }
 
     public String project() {
@@ -430,7 +428,6 @@ public String project() {
      * @param filter used to wait to detect that a pod is up and running.
      */
     public void awaitPodReadinessOrFail(Predicate<Pod> filter) {
-        /** rls TODO uncomment code and resolve compile issue. https://github.com/arquillian/arquillian-cube/issues/1282
         await().atMost(5, TimeUnit.MINUTES).until(() -> {
                 List<Pod> list = client.pods().inNamespace(namespace).list().getItems();
                 return list.stream()
@@ -439,7 +436,6 @@ public void awaitPodReadinessOrFail(Predicate<Pod> filter) {
                     .collect(Collectors.toList()).size() >= 1;
             }
         );
-        **/
     }
 
     /**

openshift/openshift/pom.xml

@@ -216,6 +216,10 @@
       <artifactId>arquillian-junit-container</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.hamcrest</groupId>
+      <artifactId>hamcrest</artifactId>
+    </dependency>
   </dependencies>
 
 </project>

openshift/openshift/src/main/java/org/arquillian/cube/openshift/impl/client/ResourceUtil.java

@@ -190,7 +190,6 @@ public static Binding toBinding(Service pod) {
      */
     public static void awaitRoute(URL routeUrl, int timeout, TimeUnit timeoutUnit, int repetitions, int... statusCodes) {
         AtomicInteger successfulAwaitsInARow = new AtomicInteger(0);
-        /** rls TODO https://github.com/arquillian/arquillian-cube/issues/1282
         await().atMost(timeout, timeoutUnit).until(() -> {
             if (tryConnect(routeUrl, statusCodes)) {
                 successfulAwaitsInARow.incrementAndGet();
@@ -199,7 +198,6 @@ public static void awaitRoute(URL routeUrl, int timeout, TimeUnit timeoutUnit, i
             }
             return successfulAwaitsInARow.get() >= repetitions;
         });
-        **/
     }
 
     public static void awaitRoute(URL routeUrl, int timeout, TimeUnit timeoutUnit, int... statusCodes) {

pom.xml

@@ -436,6 +436,11 @@
         <version>${version.hamcrest}</version>
         <scope>test</scope>
       </dependency>
+      <dependency>
+        <groupId>org.hamcrest</groupId>
+        <artifactId>hamcrest</artifactId>
+        <version>${version.hamcrest}</version>
+      </dependency>
       <dependency>
         <groupId>io.fabric8</groupId>
         <artifactId>kubernetes-client</artifactId>