Refactor closing entry behavior and enhance ledger locking.

Updated ledger locking/unlocking logic to ensure data consistency during posting, unposting, and deletion of closing entries. Adjusted form input attributes and enhanced `mark_as_posted` and `mark_as_unposted` methods for better handling of entity metadata.

Author: elarroba

django_ledger/forms/closing_entry.py

@@ -26,7 +26,8 @@ class Meta:
             'closing_date': DateInput(attrs={
                 'class': DJANGO_LEDGER_FORM_INPUT_CLASSES + ' is-large',
                 'placeholder': _('Closing Date (YYYY-MM-DD)...'),
-                'id': 'djl-datepicker'
+                'id': 'djl-datepicker',
+                'type': 'date'
             })
         }
         labels = {

django_ledger/models/closing_entry.py

@@ -123,7 +123,9 @@ def migrate(self):
         ce_txs_gb = groupby(ce_txs, key=lambda k: k.tx_type)
 
         # adding DEBITS and CREDITS...
-        ce_txs_sum = {k: sum(v.balance for v in l) for k, l in ce_txs_gb}
+        ce_txs_sum = {
+            k: sum(v.balance for v in l) for k, l in ce_txs_gb
+        }
 
         if len(ce_txs_sum) and ce_txs_sum[TransactionModel.DEBIT] != ce_txs_sum[TransactionModel.CREDIT]:
             raise ClosingEntryValidationError(
@@ -170,6 +172,8 @@ def migrate(self):
         for k, je_model in ce_txs_journal_entries.items():
             je_model.save(verify=True)
 
+        self.ledger_model.lock(commit=True, raise_exception=True)
+
         return ce_txs_journal_entries, ce_je_txs
 
     def create_entry_ledger(self, commit: bool = False):
@@ -178,7 +182,7 @@ def create_entry_ledger(self, commit: bool = False):
                 name=f'Closing Entry {self.closing_date} Ledger',
                 entity_id=self.entity_model_id,
                 hidden=True,
-                locked=True,
+                locked=False,
                 posted=True
             )
             ledger_model.clean()
@@ -195,7 +199,7 @@ def create_entry_ledger(self, commit: bool = False):
     def can_post(self) -> bool:
         return not self.is_posted()
 
-    def mark_as_posted(self, commit: bool = False, update_entity_meta: bool = False, **kwargs):
+    def mark_as_posted(self, commit: bool = False, update_entity_meta: bool = True, **kwargs):
         if not self.can_post():
             raise ClosingEntryValidationError(
                 message=_(f'Closing Entry {self.closing_date} is already posted.')
@@ -232,11 +236,14 @@ def get_mark_as_posted_url(self, entity_slug: Optional[str] = None) -> str:
     def can_unpost(self) -> bool:
         return self.is_posted()
 
-    def mark_as_unposted(self, commit: bool = False, update_entity_meta: bool = False, **kwargs):
+    def mark_as_unposted(self, commit: bool = False, update_entity_meta: bool = True, **kwargs):
         if not self.can_unpost():
             raise ClosingEntryValidationError(
                 message=_(f'Closing Entry {self.closing_date} is not posted.')
             )
+
+        self.ledger_model.unlock(commit=False, raise_exception=True)
+        self.ledger_model.save(update_fields=['posted', 'locked', 'updated'])
         self.posted = False
 
         TransactionModel.objects.for_entity(
@@ -311,6 +318,8 @@ def delete(self, **kwargs):
                 message=_('Cannot delete a posted Closing Entry')
             )
 
+        self.ledger_model.unpost(commit=True, raise_exception=True)
+
         TransactionModel.objects.for_entity(
             entity_slug=self.entity_model_id
         ).for_ledger(ledger_model=self.ledger_model).delete()