- **Refactored forms and staged transaction handling:**

  - Consolidated and streamlined widgets, labels, and help texts for `TransactionModelForm`, `BankAccountCreateForm`, and `StagedTransactionModelForm` for consistency and usability.
  - Simplified queryset filters, removed redundant queries, and enhanced `BaseStagedTransactionModelFormSet` to handle more dynamic setups (e.g., `children`, `units`, `vendors`).
  - Improved `tx_import`, `tx_split`, and `bundle_split` handling logic with clearer validation and dynamic element visibility for child transactions and account selections.
  - Enhanced validation and cleaned data logic for specific fields including `matched_transaction` and `activity`.

- **Enhanced `BankAccountModel` account selection:**
  - Expanded filters for account roles in `BankAccountCreateForm` and `BankAccountUpdateForm` to include `LIABILITY_CL_CREDIT_LINE`.
  - Adjusted widget definitions to improve uniformity and provide better placeholders and help texts.

- **Major improvements to transaction matching logics:**
  - Added mechanisms to dynamically adjust querysets for match candidates against transfers and debt payments.
  - Introduced informative error messages for ambiguous match cases, ensuring user clarity in selection.

### **

Author: elarroba

django_ledger/forms/bank_account.py

@@ -1,29 +1,36 @@
-from django.forms import ModelForm, TextInput, Select, ValidationError
+from django.forms import ModelForm, Select, TextInput, ValidationError
 from django.utils.translation import gettext_lazy as _
 
-from django_ledger.io.roles import ASSET_CA_CASH, LIABILITY_CL_ACC_PAYABLE, LIABILITY_LTL_MORTGAGE_PAYABLE
+from django_ledger.io.roles import (
+    ASSET_CA_CASH,
+    LIABILITY_CL_ACC_PAYABLE,
+    LIABILITY_CL_CREDIT_LINE,
+    LIABILITY_LTL_MORTGAGE_PAYABLE,
+)
 from django_ledger.models import BankAccountModel
 from django_ledger.models.accounts import AccountModel
 from django_ledger.settings import DJANGO_LEDGER_FORM_INPUT_CLASSES
 
 
 class BankAccountCreateForm(ModelForm):
-
     def __init__(self, *args, entity_slug, user_model, **kwargs):
         super().__init__(*args, **kwargs)
         self.ENTITY_SLUG = entity_slug
         self.USER_MODEL = user_model
 
         # todo: only the accounts that do not hava an associated bank account should be available to pick from...
-        account_qs = AccountModel.objects.for_entity(
-            user_model=self.USER_MODEL,
-            entity_model=self.ENTITY_SLUG
-        ).available().filter(
-            role__in=[
-                ASSET_CA_CASH,
-                LIABILITY_CL_ACC_PAYABLE,
-                LIABILITY_LTL_MORTGAGE_PAYABLE
-            ])
+        account_qs = (
+            AccountModel.objects.for_entity(user_model=self.USER_MODEL, entity_model=self.ENTITY_SLUG)
+            .available()
+            .filter(
+                role__in=[
+                    ASSET_CA_CASH,
+                    LIABILITY_CL_ACC_PAYABLE,
+                    LIABILITY_LTL_MORTGAGE_PAYABLE,
+                    LIABILITY_CL_CREDIT_LINE,
+                ]
+            )
+        )
         self.fields['account_model'].queryset = account_qs
 
     def clean(self):
@@ -36,9 +43,7 @@ def clean(self):
 
         # catching unique database constraint...
         if BankAccountModel.objects.filter(
-                account_model=account_model,
-                routing_number__exact=routing_number,
-                account_number__exact=account_number
+            account_model=account_model, routing_number__exact=routing_number, account_number__exact=account_number
         ).exists():
             raise ValidationError('Duplicate bank account model.')
 
@@ -52,35 +57,26 @@ class Meta:
             'aba_number',
             'swift_number',
             'account_model',
-            'active'
+            'active',
         ]
         widgets = {
-            'name': TextInput(attrs={
-                'class': DJANGO_LEDGER_FORM_INPUT_CLASSES,
-                'placeholder': _('Enter account name...')
-            }),
-            'account_number': TextInput(attrs={
-                'class': DJANGO_LEDGER_FORM_INPUT_CLASSES,
-                'placeholder': _('Enter account number...')
-            }),
-            'routing_number': TextInput(attrs={
-                'class': DJANGO_LEDGER_FORM_INPUT_CLASSES,
-                'placeholder': _('Enter routing number...')
-            }),
-            'aba_number': TextInput(attrs={
-                'class': DJANGO_LEDGER_FORM_INPUT_CLASSES,
-                'placeholder': _('Enter ABA number...')
-            }),
-            'swift_number': TextInput(attrs={
-                'class': DJANGO_LEDGER_FORM_INPUT_CLASSES,
-                'placeholder': _('Enter SWIFT number...')
-            }),
-            'account_type': Select(attrs={
-                'class': DJANGO_LEDGER_FORM_INPUT_CLASSES
-            }),
-            'account_model': Select(attrs={
-                'class': DJANGO_LEDGER_FORM_INPUT_CLASSES
-            })
+            'name': TextInput(
+                attrs={'class': DJANGO_LEDGER_FORM_INPUT_CLASSES, 'placeholder': _('Enter account name...')}
+            ),
+            'account_number': TextInput(
+                attrs={'class': DJANGO_LEDGER_FORM_INPUT_CLASSES, 'placeholder': _('Enter account number...')}
+            ),
+            'routing_number': TextInput(
+                attrs={'class': DJANGO_LEDGER_FORM_INPUT_CLASSES, 'placeholder': _('Enter routing number...')}
+            ),
+            'aba_number': TextInput(
+                attrs={'class': DJANGO_LEDGER_FORM_INPUT_CLASSES, 'placeholder': _('Enter ABA number...')}
+            ),
+            'swift_number': TextInput(
+                attrs={'class': DJANGO_LEDGER_FORM_INPUT_CLASSES, 'placeholder': _('Enter SWIFT number...')}
+            ),
+            'account_type': Select(attrs={'class': DJANGO_LEDGER_FORM_INPUT_CLASSES}),
+            'account_model': Select(attrs={'class': DJANGO_LEDGER_FORM_INPUT_CLASSES}),
         }
         labels = {
             'name': _('Account Name'),
@@ -96,23 +92,13 @@ class Meta:
 class BankAccountUpdateForm(BankAccountCreateForm):
     class Meta:
         model = BankAccountModel
-        fields = [
-            'name',
-            'account_type',
-            'account_model',
-            'active'
-        ]
+        fields = ['name', 'account_type', 'account_model', 'active']
         widgets = {
-            'name': TextInput(attrs={
-                'class': DJANGO_LEDGER_FORM_INPUT_CLASSES,
-                'placeholder': _('Enter account name...')
-            }),
-            'account_type': Select(attrs={
-                'class': DJANGO_LEDGER_FORM_INPUT_CLASSES
-            }),
-            'account_model': Select(attrs={
-                'class': DJANGO_LEDGER_FORM_INPUT_CLASSES
-            })
+            'name': TextInput(
+                attrs={'class': DJANGO_LEDGER_FORM_INPUT_CLASSES, 'placeholder': _('Enter account name...')}
+            ),
+            'account_type': Select(attrs={'class': DJANGO_LEDGER_FORM_INPUT_CLASSES}),
+            'account_model': Select(attrs={'class': DJANGO_LEDGER_FORM_INPUT_CLASSES}),
         }
 
     def clean(self):
@@ -124,8 +110,8 @@ def clean(self):
         # catching unique database constraint...
         if 'cash_account' in self.changed_data:
             if BankAccountModel.objects.filter(
-                    cash_account=cash_account,
-                    routing_number__exact=self.instance.routing_number,
-                    account_number__exact=self.instance.account_number
+                cash_account=cash_account,
+                routing_number__exact=self.instance.routing_number,
+                account_number__exact=self.instance.account_number,
             ).exists():
                 raise ValidationError('Duplicate bank account model.')