Skip to content

Commit 1b8ab55

Browse files
committed
address review comments
1 parent 9892e2a commit 1b8ab55

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

docs/proposal/controller-and-user-tags.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@ This proposal presents adding two kinds of tags to the resources created by cont
2727
Tags of format`powervs.cluster.x-k8s.io/owner: <cluster-name>` and `powervs.cluster.x-k8s.io/cluster-uuid: UUID` will be added by the controller to newly created cloud resources marking the resource as created by controller. During deletion phase the system will look for the presence of both the
2828
tags and match inorder to proceed with deletion or to keep as it is. UUID in tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` is cluster object ID
2929
We will be adding two tags. Below are the cluster creation scenarios.
30-
#### Creating a new cluster with infrastructure creation
30+
#### Creating a new cluster
3131
- When resources will be created for new cluster in the cloud both the tags will be attached.
32-
#### Creating a new cluster with existing cluster
32+
#### Creating a new cluster with reusing pre-created resources
3333
- When cluster is created using existing resources, no tags will be attached.
34-
#### Creating a new cluster with infra creation and resources already exist with same clusterName.
35-
- So when new cluster creation is triggered with creating infrastructure. Since the resources are already present with same name in the cloud. It will lead to security issues Since there is a possibilty the existing resources in the cloud belong to different user. So to handle this case this tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` is added. Before creating the resource in the cloud, first will check this tag is matching `powervs.cluster.x-k8s.io/owner: <cluster-name>` since clusterName is same but this tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` won't match. So will error out to user that resources with similar name already exist, he has to provide different name.
34+
#### Creating a new cluster with reusing pre-created resources from old cluster.
35+
- So when new cluster creation is triggered, since the resources are already present with same name in the cloud. It will lead to security issues because there is a possibilty the existing resources in the cloud belong to different user. So to handle this case this tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` is added. Before creating the resource in the cloud, first will check this tag is matching `powervs.cluster.x-k8s.io/owner: <cluster-name>` since clusterName is same but this tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` won't match. So will error out to user that resources with similar name already exist, he has to provide different name.
3636

3737

3838
#### Following resources will be getting tagged

0 commit comments

Comments
 (0)