Skip to content

Commit 6e2ff73

Browse files
committed
address review comments
1 parent 9892e2a commit 6e2ff73

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

docs/proposal/controller-and-user-tags.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,16 @@ This proposal presents adding two kinds of tags to the resources created by cont
2424

2525

2626
### Controller tags
27-
Tags of format`powervs.cluster.x-k8s.io/owner: <cluster-name>` and `powervs.cluster.x-k8s.io/cluster-uuid: UUID` will be added by the controller to newly created cloud resources marking the resource as created by controller. During deletion phase the system will look for the presence of both the
27+
Tags of format`powervs.cluster.x-k8s.io/owner: <cluster-name>` and `powervs.cluster.x-k8s.io/cluster-uuid: UUID` will be added by the controller to newly created cloud resources marking the resource as created by controller. When cluster creation is triggered with clustername "test-cluster", resources "test-cluster-serviceInstance, test-cluster-VPC, test-cluster-loadbalancer, test-cluster-TransitGateway, test-cluster-COSInstance" are created
28+
When new cluster creation is triggered, if the resources are already present with same name in the cloud. It will lead to security issues because there is a possibilty the existing resources in the cloud belong to different user. So to handle this scenario this tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` is added. During deletion phase the system will look for the presence of both the
2829
tags and match inorder to proceed with deletion or to keep as it is. UUID in tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` is cluster object ID
2930
We will be adding two tags. Below are the cluster creation scenarios.
30-
#### Creating a new cluster with infrastructure creation
31+
#### Creating a new cluster
3132
- When resources will be created for new cluster in the cloud both the tags will be attached.
32-
#### Creating a new cluster with existing cluster
33+
#### Creating a new cluster with reusing pre-created resources
3334
- When cluster is created using existing resources, no tags will be attached.
34-
#### Creating a new cluster with infra creation and resources already exist with same clusterName.
35-
- So when new cluster creation is triggered with creating infrastructure. Since the resources are already present with same name in the cloud. It will lead to security issues Since there is a possibilty the existing resources in the cloud belong to different user. So to handle this case this tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` is added. Before creating the resource in the cloud, first will check this tag is matching `powervs.cluster.x-k8s.io/owner: <cluster-name>` since clusterName is same but this tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` won't match. So will error out to user that resources with similar name already exist, he has to provide different name.
35+
#### Creating a new cluster with reusing pre-created resources from old cluster.
36+
- When creating the resources in the cloud, first will check this tag is matching `powervs.cluster.x-k8s.io/owner: <cluster-name>` since resources already exists with same name but this tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` won't match. So will error out to user that resources with similar name already exist, he has to provide different name to cluster.
3637

3738

3839
#### Following resources will be getting tagged

0 commit comments

Comments
 (0)