Fix VPC cluster reconcileV2 delete flow (kubernetes-sigs#2438)

Amulyam24 · web-flow · commit d61297d52497 · 2025-07-28T07:00:29.000-07:00
diff --git a/controllers/ibmvpccluster_controller.go b/controllers/ibmvpccluster_controller.go
@@ -371,8 +371,10 @@ func (r *IBMVPCClusterReconciler) reconcileDelete(clusterScope *scope.ClusterSco
 	return handleFinalizerRemoval(clusterScope)
 }
 
-func (r *IBMVPCClusterReconciler) reconcileDeleteV2(_ *scope.VPCClusterScope) (ctrl.Result, error) {
-	return ctrl.Result{}, fmt.Errorf("not implemented")
+func (r *IBMVPCClusterReconciler) reconcileDeleteV2(clusterScope *scope.VPCClusterScope) (ctrl.Result, error) { //nolint:unparam
+	clusterScope.Info("Delete cluster is not implemented for reconcile v2")
+	controllerutil.RemoveFinalizer(clusterScope.IBMVPCCluster, infrav1.ClusterFinalizer)
+	return ctrl.Result{}, nil
 }
 
 func (r *IBMVPCClusterReconciler) getOrCreate(clusterScope *scope.ClusterScope) (*vpcv1.LoadBalancer, error) {

Original file line number	Diff line number	Diff line change
`@@ -371,8 +371,10 @@ func (r IBMVPCClusterReconciler) reconcileDelete(clusterScope scope.ClusterSco`
`371`	`371`	`return handleFinalizerRemoval(clusterScope)`
`372`	`372`	`}`
`373`	`373`
`374`		`-func (r IBMVPCClusterReconciler) reconcileDeleteV2(_ scope.VPCClusterScope) (ctrl.Result, error) {`
`375`		`- return ctrl.Result{}, fmt.Errorf("not implemented")`
	`374`	`+func (r IBMVPCClusterReconciler) reconcileDeleteV2(clusterScope scope.VPCClusterScope) (ctrl.Result, error) { //nolint:unparam`
	`375`	`+ clusterScope.Info("Delete cluster is not implemented for reconcile v2")`
	`376`	`+ controllerutil.RemoveFinalizer(clusterScope.IBMVPCCluster, infrav1.ClusterFinalizer)`
	`377`	`+ return ctrl.Result{}, nil`
`376`	`378`	`}`
`377`	`379`
`378`	`380`	`func (r IBMVPCClusterReconciler) getOrCreate(clusterScope scope.ClusterScope) (*vpcv1.LoadBalancer, error) {`