Remove exteranl cloud-provider flag from apiserver (kubernetes-sigs#2415)

Author: Karthik-K-N

templates/cluster-template-powervs-clusterclass.yaml

@@ -88,9 +88,6 @@ spec:
             certSANs:
             - ${IBMPOWERVS_VIP}
             - ${IBMPOWERVS_VIP_EXTERNAL}
-            extraArgs:
-            - name: cloud-provider
-              value: external
           controlPlaneEndpoint: ${IBMPOWERVS_VIP}:${API_SERVER_PORT:=6443}
           controllerManager:
             extraArgs:

templates/cluster-template-powervs-clusterclass/cluster-with-kcp.yaml

@@ -88,9 +88,6 @@ spec:
             certSANs:
               - "${IBMPOWERVS_VIP}"
               - "${IBMPOWERVS_VIP_EXTERNAL}"
-            extraArgs:
-              - name: cloud-provider
-                value: external
           controlPlaneEndpoint: ${IBMPOWERVS_VIP}:${API_SERVER_PORT:=6443}
           controllerManager:
             extraArgs:

templates/cluster-template-powervs-create-infra.yaml

@@ -57,10 +57,6 @@ metadata:
 spec:
   kubeadmConfigSpec:
     clusterConfiguration:
-      apiServer:
-        extraArgs:
-        - name: cloud-provider
-          value: external
       controllerManager:
         extraArgs:
         - name: cloud-provider

templates/cluster-template-powervs.yaml

@@ -48,9 +48,6 @@ spec:
         certSANs:
         - ${IBMPOWERVS_VIP}
         - ${IBMPOWERVS_VIP_EXTERNAL}
-        extraArgs:
-        - name: cloud-provider
-          value: external
       controlPlaneEndpoint: ${IBMPOWERVS_VIP}:${API_SERVER_PORT:=6443}
       controllerManager:
         extraArgs:

templates/cluster-template-powervs/kcp.yaml

@@ -5,10 +5,6 @@ metadata:
 spec:
   kubeadmConfigSpec:
     clusterConfiguration:
-      apiServer:
-        extraArgs:
-        - name: cloud-provider
-          value: external
       controllerManager:
         extraArgs:
         - name: cloud-provider

templates/cluster-template-vpc-clusterclass.yaml

@@ -90,9 +90,6 @@ spec:
             certSANs:
             - localhost
             - 127.0.0.1
-            extraArgs:
-            - name: cloud-provider
-              value: external
           controllerManager:
             extraArgs:
             - name: enable-hostpath-provisioner

templates/cluster-template-vpc-clusterclass/cluster-with-kcp.yaml

@@ -88,9 +88,6 @@ spec:
         clusterConfiguration:
           apiServer:
             certSANs: [localhost, 127.0.0.1]
-            extraArgs:
-              - name: cloud-provider
-                value: external
           controllerManager:
             extraArgs:
               - name: enable-hostpath-provisioner

templates/cluster-template.yaml

@@ -50,9 +50,6 @@ spec:
         certSANs:
         - localhost
         - 127.0.0.1
-        extraArgs:
-        - name: cloud-provider
-          value: external
       controllerManager:
         extraArgs:
         - name: cloud-provider

templates/cluster-template/kcp.yaml

@@ -10,7 +10,3 @@ spec:
         extraArgs:
         - name: cloud-provider
           value: external
-      apiServer:
-        extraArgs:
-        - name: cloud-provider
-          value: external

test/e2e/data/templates/cluster-template-powervs-md-remediation.yaml

@@ -354,9 +354,6 @@ spec:
         certSANs:
         - ${IBMPOWERVS_VIP}
         - ${IBMPOWERVS_VIP_EXTERNAL}
-        extraArgs:
-        - name: cloud-provider
-          value: external
       controlPlaneEndpoint: ${IBMPOWERVS_VIP}:${API_SERVER_PORT:=6443}
       controllerManager:
         extraArgs: