ci: update golangci-lint setup and version

Author: arsham

.github/workflows/go.yml

@@ -57,5 +57,5 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v2
         with:
-          version: v1.44.2
+          version: v1.45.0
           args: --timeout 5m0s

.golangci.yml

@@ -1,6 +1,33 @@
 linters-settings:
+  funlen:
+    lines: 100
+    statements: 50
+  cyclop:
+    skip-tests: true
+    max-complexity: 30
+    package-average: 5
+  gocyclo:
+    min-complexity: 15
+  gofumpt:
+    lang-version: "1.18"
+  goimports:
+    local-prefixes: github.com/golangci/golangci-lint
+  goconst:
+    min-len: 2
+    min-occurrences: 3
+  gocritic:
+    enabled-tags:
+      - diagnostic
+      - experimental
+      - opinionated
+      - performance
+      - style
+  godot:
+    capital: true
+  gosimple:
+    go: "1.18"
+    checks: ["all"]
   govet:
-    check-shadowing: true
     settings:
       printf:
         funcs:
@@ -9,35 +36,49 @@ linters-settings:
           - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
           - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
     enable:
+      - assign
+      - atomic
+      - atomicalign
+      - bools
+      - buildtag
+      - cgocall
+      - composites
+      - copylocks
+      - deepequalerrors
+      - errorsas
       - fieldalignment
-  gocyclo:
-    min-complexity: 15
+      - findcall
+      - framepointer
+      - httpresponse
+      - ifaceassert
+      - loopclosure
+      - lostcancel
+      - nilfunc
+      - printf
+      - reflectvaluecompare
+      - shift
+      - sigchanyzer
+      - sortslice
+      - stdmethods
+      - stringintconv
+      - structtag
+      - testinggoroutine
+      - tests
+      - unmarshal
+      - unreachable
+      - unsafeptr
+      - unusedresult
+
   maligned:
     suggest-new: true
-  goconst:
-    min-len: 2
-    min-occurrences: 2
   misspell:
     locale: UK
-  lll:
-    line-length: 140
-  goimports:
-    local-prefixes: github.com/golangci/golangci-lint
-  gocritic:
-    enabled-tags:
-      - diagnostic
-      - experimental
-      - opinionated
-      - performance
-      - style
-    disabled-checks:
-      - wrapperFunc
-      - dupImport # https://github.com/go-critic/go-critic/issues/845
-  funlen:
-    lines: 100
-    statements: 50
-  godot:
-    capital: true
+  staticcheck:
+    go: "1.18"
+    checks: ["all"]
+  stylecheck:
+    go: "1.18"
+    checks: ["all"]
   unparam:
     check-exported: true
 
@@ -51,27 +92,33 @@ issues:
         - govet
         - errcheck
         - forcetypeassert
+  fix: true
+  exclude-use-default: false
 
 run:
+  timeout: 5m
   skip-dirs:
     - model
     - tmp
     - bin
     - scripts
-
+  allow-parallel-runners: true
   tests: true
   build-tags:
     - integration
 
 linters:
   enable:
+    - bidichk
     - bodyclose
+    - cyclop
     - deadcode
     - depguard
     - dogsled
     - dupl
     - durationcheck
     - errcheck
+    - errname
     - errorlint
     - exportloopref
     - forcetypeassert
@@ -80,7 +127,8 @@ linters:
     - gocritic
     - gocyclo
     - godot
-    - godox
+    - gofmt
+    - gofumpt
     - goprintffuncname
     - gosec
     - gosimple
@@ -90,13 +138,17 @@ linters:
     - nakedret
     - nestif
     - nilerr
+    - noctx
     - prealloc
+    - predeclared
+    - promlinter
     - revive
     - rowserrcheck
     - sqlclosecheck
     - staticcheck
     - structcheck
     - stylecheck
+    - tenv
     - tparallel
     - typecheck
     - unconvert
@@ -105,10 +157,3 @@ linters:
     - varcheck
     - wastedassign
     - whitespace
-
-# golangci.com configuration
-# https://github.com/golangci/golangci/wiki/Configuration
-service:
-  golangci-lint-version: 1.44.x
-  prepare:
-    - echo "here I can run custom commands, but no preparation needed for this repo"

Makefile

@@ -29,10 +29,10 @@ ci_tests: ## Run tests for CI.
 
 .PHONY: dependencies
 dependencies: ## Install dependencies requried for development operations.
-	@go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.44.2
 	@go install github.com/cespare/reflex@latest
 	@go get github.com/stretchr/testify/mock
 	@go get github.com/vektra/mockery/.../
+	@go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.45.0
 	@go mod tidy
 
 .PHONY: clean

contract.go

@@ -1,3 +1,5 @@
+// Package dbtools contains logic for database transaction, using the retry
+// library.
 package dbtools
 
 import (

dbtesting/dbtesting.go

@@ -1,3 +1,4 @@
+// Package dbtesting provides handy tools for using with databases.
 package dbtesting
 
 import (