Skip to content

Commit 834a34f

Browse files
committed
1.3.3
1 parent 03f8425 commit 834a34f

File tree

6 files changed

+31
-15
lines changed

6 files changed

+31
-15
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 1.3.3 (2014-09-30)
2+
3+
- Due to [angular.js@fca6be71](https://github.com/angular/angular.js/commit/fca6be71), filters are now flagged as `$stateful=true` for compatibility reasons ([03f8425](https://github.com/artch/angular-route-segment/commit/03f8425)).
4+
15
# 1.3.2 (2014-09-19)
26

37
- Fixed a case when `watcher` is provided in annotated array form rather than as a function ([84602](https://github.com/artch/angular-route-segment/commit/84602f83fbb20d336f0fdc3d34a22d7834a6489b)).

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,8 @@ $routeSegment.getSegmentUrl('s1.itemInfo.edit', {id: 123}); // -> '/section1
269269
270270
### Filters ###
271271
272+
**ATTENTION:** filters are not stateless. While they are not intented to work with complex data structures, it can impact performance anyway. See more info at [angular.js commit fca6be71](https://github.com/angular/angular.js/commit/fca6be71).
273+
272274
##### routeSegmentEqualsTo
273275
274276
A wrapper for `$routeSegment.name == value`.

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-route-segment",
3-
"version": "1.3.2",
3+
"version": "1.3.3",
44
"main": "build/angular-route-segment.js",
55
"ignore": [
66
"**/.*",

build/angular-route-segment.js

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* angular-route-segment 1.3.2
2+
* angular-route-segment 1.3.3
33
* https://angular-route-segment.com
44
* @author Artem Chivchalov
55
* @license MIT License http://opensource.org/licenses/MIT
@@ -498,49 +498,59 @@ mod.provider( '$routeSegment',
498498
* <a ng-href="{{ 'index.list.itemInfo' | routeSegmentUrl: {id: 123} }}">
499499
*/
500500
mod.filter('routeSegmentUrl', ['$routeSegment', function($routeSegment) {
501-
return function(segmentName, params) {
501+
var filter = function(segmentName, params) {
502502
return $routeSegment.getSegmentUrl(segmentName, params);
503-
}
503+
};
504+
filter.$stateful = true;
505+
return filter;
504506
}]);
505507

506508
/**
507509
* Usage:
508510
* <li ng-class="{active: ('index.list' | routeSegmentEqualsTo)}">
509511
*/
510512
mod.filter('routeSegmentEqualsTo', ['$routeSegment', function($routeSegment) {
511-
return function(value) {
513+
var filter = function(value) {
512514
return $routeSegment.name == value;
513-
}
515+
};
516+
filter.$stateful = true;
517+
return filter;
514518
}]);
515519

516520
/**
517521
* Usage:
518522
* <li ng-class="{active: ('section1' | routeSegmentStartsWith)}">
519523
*/
520524
mod.filter('routeSegmentStartsWith', ['$routeSegment', function($routeSegment) {
521-
return function(value) {
525+
var filter = function(value) {
522526
return $routeSegment.startsWith(value);
523-
}
527+
};
528+
filter.$stateful = true;
529+
return filter;
524530
}]);
525531

526532
/**
527533
* Usage:
528534
* <li ng-class="{active: ('itemInfo' | routeSegmentContains)}">
529535
*/
530536
mod.filter('routeSegmentContains', ['$routeSegment', function($routeSegment) {
531-
return function(value) {
537+
var filter = function(value) {
532538
return $routeSegment.contains(value);
533-
}
539+
};
540+
filter.$stateful = true;
541+
return filter;
534542
}]);
535543

536544
/**
537545
* Usage:
538546
* <li ng-class="{active: ('index.list.itemInfo' | routeSegmentEqualsTo) && ('id' | routeSegmentParam) == 123}">
539547
*/
540548
mod.filter('routeSegmentParam', ['$routeSegment', function($routeSegment) {
541-
return function(value) {
549+
var filter = function(value) {
542550
return $routeSegment.$routeParams[value];
543-
}
551+
};
552+
filter.$stateful = true;
553+
return filter;
544554
}]);
545555

546556

build/angular-route-segment.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-route-segment",
3-
"version": "1.3.2",
3+
"version": "1.3.3",
44
"dependencies": {
55
"grunt": "",
66
"grunt-contrib-uglify": "",

0 commit comments

Comments
 (0)