[v1.0.1] Fixes bug in "is edge flip needed' test #39
artem-ogre
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Overview
Bug-fix release: fix an error in code that tests if an edge flip is required.
Issue: #37
Fixing PR: #38
Fix Details
Previously flip was rejected only if both vertices of flip-candidate edge belong to the super-triangle.
This sometimes resulted in wrong edges and incorrect convex-hull.
The change: instead reject the edge-flip if
If the case when both original edge and flip-candidate edge touch super-triangle use normal circumcircle test as a tie-breaker.
Two test files for regression testing are added.
This discussion was created from the release [v1.0.1] Fixes bug in "is edge flip needed' test.
Beta Was this translation helpful? Give feedback.
All reactions