Construct request URL in APIClient

Remove the optional `url` requirement from HTTPRequestProtocol and the `url` computed property extension. Move URL construction into APIClient by combining `baseURL` and `path` (using `appendingPathComponent`). Remove the BadURLRequest mock and the unit test that asserted a `.badURL` error, since requests no longer expose a nullable URL. This centralizes URL creation and simplifies request implementations.

Author: artemkalinovsky

Sources/Kite/APIClient.swift

@@ -38,10 +38,7 @@ public final class APIClient: Sendable {
         deserializer: any ResponseDataDeserializer<T>,
         additionalHeaders: [String: String]
     ) async throws -> (T, URLResponse) {
-        guard let url = request.url else {
-            throw URLError(.badURL)
-        }
-
+        let url = request.baseURL.appendingPathComponent(request.path)
         var urlRequest = URLRequest(url: url)
         urlRequest.httpMethod = request.method.rawValue
 

Sources/Kite/Extensions/HTTPRequestProtocol+Extensions.swift

@@ -1,10 +1,6 @@
 import Foundation
 
 extension HTTPRequestProtocol {
-    public var url: URL? {
-        baseURL.appendingPathComponent(self.path)
-    }
-
     public var path: String {
         ""
     }

Sources/Kite/Protocols/HTTPRequestProtocol.swift

@@ -2,7 +2,6 @@ import Foundation
 
 public protocol HTTPRequestProtocol {
     var baseURL: URL { get }
-    var url: URL? { get }
     var path: String { get }
     var parameters: [String: any Sendable]? { get }
     var method: HTTPMethod { get }

Tests/KiteTests/APIClientTests/APIClientTests.swift

@@ -127,19 +127,6 @@ struct APIClientTests {
         _ = try await client.execute(request: dummyRequest)
     }
 
-    @Test("execute(request:) throws badURL when url is nil")
-    func testExecuteThrowsOnBadURL() async throws {
-        let client = APIClient(urlSession: makeMockSession())
-        let dummyRequest = BadURLRequest()
-
-        await #expect(throws: URLError.self) {
-            _ = try await client.execute(
-                request: dummyRequest,
-                deserializer: VoidDeserializer()
-            )
-        }
-    }
-
     @Test("execute(request:) throws unacceptableStatusCode on non-2xx response")
     func testExecuteThrowsOnHTTPErrorStatusCode() async throws {
         let client = APIClient(urlSession: makeMockSession())