refactor: Fix and test repository resolution

Author: ollieread

src/Concise.php

@@ -244,10 +244,10 @@ public function repository(string $class): Repository
          *
          * @phpstan-ignore argument.type
          */
-        return $this->repositories[$class] = $this->app->make($repositoryClass, [
-            'concise'    => $this,
-            'mapper'     => $mapper,
-            'connection' => $this->databases->connection($mapper->connection()),
-        ]);
+        return $this->repositories[$class] = new $repositoryClass(
+            concise   : $this,
+            mapper    : $mapper,
+            connection: $this->databases->connection($mapper->connection()),
+        );
     }
 }

src/Contracts/Repository.php

@@ -2,10 +2,24 @@
 
 namespace Articulate\Concise\Contracts;
 
+use Articulate\Concise\Concise;
+use Illuminate\Database\Connection;
+
 /**
  * @template EntityType of object
  */
 interface Repository
 {
-
+    /**
+     * Create a new repository instance.
+     *
+     * @param \Articulate\Concise\Concise                            $concise
+     * @param \Articulate\Concise\Contracts\EntityMapper<EntityType> $mapper
+     * @param \Illuminate\Database\Connection                        $connection
+     */
+    public function __construct(
+        Concise      $concise,
+        EntityMapper $mapper,
+        Connection   $connection
+    );
 }

src/Support/BaseRepository.php

@@ -3,6 +3,7 @@
 
 namespace Articulate\Concise\Support;
 
+use App\Models\User;
 use Articulate\Concise\Concise;
 use Articulate\Concise\Contracts\EntityMapper;
 use Articulate\Concise\Contracts\Repository;
@@ -40,7 +41,7 @@ abstract class BaseRepository implements Repository
     public function __construct(
         Concise      $concise,
         EntityMapper $mapper,
-        Connection   $connection
+        Connection   $connection,
     )
     {
         $this->concise    = $concise;

tests/ConciseTest.php

@@ -10,6 +10,7 @@
 use App\Mappers\Components\TimestampsMapper;
 use App\Mappers\Entities\UserMapper;
 use App\Providers\MapperServiceProvider;
+use App\Repositories\UserRepository;
 use Articulate\Concise\Concise;
 use Articulate\Concise\ConciseServiceProvider;
 use PHPUnit\Framework\Attributes\Test;
@@ -58,4 +59,15 @@ public function hasRegisteredMappersSuccessfully(): void
         $this->assertInstanceOf(AuthCredentialsMapper::class, $componentMappers[AuthCredentials::class]);
         $this->assertInstanceOf(TimestampsMapper::class, $componentMappers[Timestamps::class]);
     }
+
+    #[Test]
+    public function bindsEntityRepositoriesCorrectly(): void
+    {
+        $this->assertTrue($this->app->providerIsLoaded(MapperServiceProvider::class));
+
+        $concise = $this->app->make(Concise::class);
+
+        $this->assertTrue($this->app->bound(UserRepository::class));
+        $this->assertSame($this->app->make(UserRepository::class), $concise->repository(User::class));
+    }
 }