Skip to content

Commit 92e9d4e

Browse files
committed
Fixed several issues detected by static analysis
1 parent fbb2cab commit 92e9d4e

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

modules/dnn/src/dnn.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ struct LayerPin
338338

339339
struct LayerData
340340
{
341-
LayerData() : id(-1), flag(0) {}
341+
LayerData() : id(-1), skip(false), flag(0) {}
342342
LayerData(int _id, const String &_name, const String &_type, LayerParams &_params)
343343
: id(_id), name(_name), type(_type), params(_params), skip(false), flag(0)
344344
{

modules/dnn/src/layers/pooling_layer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ class PoolingLayerImpl : public PoolingLayer
270270
int poolingType;
271271
float spatialScale;
272272

273-
PoolingInvoker() : src(0), rois(0), dst(0), mask(0), nstripes(0),
273+
PoolingInvoker() : src(0), rois(0), dst(0), mask(0), avePoolPaddedArea(false), nstripes(0),
274274
computeMaxIdx(0), poolingType(MAX), spatialScale(0) {}
275275

276276
static void run(const Mat& src, const Mat& rois, Mat& dst, Mat& mask, Size kernel,

modules/imgcodecs/src/grfmt_tiff.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -587,12 +587,13 @@ bool TiffDecoder::readData_32FC1(Mat& img)
587587
tsize_t scanlength = TIFFScanlineSize(tif);
588588
tdata_t buf = _TIFFmalloc(scanlength);
589589
float* data;
590+
bool result = true;
590591
for (uint32 row = 0; row < img_height; row++)
591592
{
592593
if (TIFFReadScanline(tif, buf, row) != 1)
593594
{
594-
close();
595-
return false;
595+
result = false;
596+
break;
596597
}
597598
data=(float*)buf;
598599
for (uint32 i=0; i<img_width; i++)
@@ -603,7 +604,7 @@ bool TiffDecoder::readData_32FC1(Mat& img)
603604
_TIFFfree(buf);
604605
close();
605606

606-
return true;
607+
return result;
607608
}
608609

609610
//////////////////////////////////////////////////////////////////////////////////////////

modules/ml/src/ann_mlp.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class SimulatedAnnealingANN_MLP
9292
double varTmp;
9393
int index;
9494
public:
95-
SimulatedAnnealingANN_MLP(ml::ANN_MLP& x, const Ptr<ml::TrainData>& d) : nn(x), data(d)
95+
SimulatedAnnealingANN_MLP(ml::ANN_MLP& x, const Ptr<ml::TrainData>& d) : nn(x), data(d), varTmp(0.0), index(0)
9696
{
9797
initVarMap();
9898
}

0 commit comments

Comments
 (0)