Skip to content

Commit cb66f82

Browse files
committed
Merge pull request opencv#10707 from alalek:update_reports
2 parents 1389fd6 + daf3368 commit cb66f82

File tree

5 files changed

+16
-10
lines changed

5 files changed

+16
-10
lines changed

modules/ts/misc/chart.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def getTest(stests, x, y, row, col):
108108
if __name__ == "__main__":
109109
parser = OptionParser()
110110
parser.add_option("-o", "--output", dest="format", help="output results in text format (can be 'txt', 'html' or 'auto' - default)", metavar="FMT", default="auto")
111-
parser.add_option("-u", "--units", dest="units", help="units for output values (s, ms (default), mks, ns or ticks)", metavar="UNITS", default="ms")
111+
parser.add_option("-u", "--units", dest="units", help="units for output values (s, ms (default), us, ns or ticks)", metavar="UNITS", default="ms")
112112
parser.add_option("-m", "--metric", dest="metric", help="output metric", metavar="NAME", default="gmean")
113113
parser.add_option("-x", "", dest="x", help="argument number for rows", metavar="ROW", default=1)
114114
parser.add_option("-y", "", dest="y", help="argument number for columns", metavar="COL", default=0)

modules/ts/misc/report.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
if __name__ == "__main__":
88
parser = OptionParser()
99
parser.add_option("-o", "--output", dest="format", help="output results in text format (can be 'txt', 'html' or 'auto' - default)", metavar="FMT", default="auto")
10-
parser.add_option("-u", "--units", dest="units", help="units for output values (s, ms (default), mks, ns or ticks)", metavar="UNITS", default="ms")
10+
parser.add_option("-u", "--units", dest="units", help="units for output values (s, ms (default), us, ns or ticks)", metavar="UNITS", default="ms")
1111
parser.add_option("-c", "--columns", dest="columns", help="comma-separated list of columns to show", metavar="COLS", default="")
1212
parser.add_option("-f", "--filter", dest="filter", help="regex to filter tests", metavar="REGEX", default=None)
1313
parser.add_option("", "--show-all", action="store_true", dest="showall", default=False, help="also include empty and \"notrun\" lines")

modules/ts/misc/summary.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def getSetName(tset, idx, columns, short = True):
3232
parser = OptionParser()
3333
parser.add_option("-o", "--output", dest="format", help="output results in text format (can be 'txt', 'html', 'markdown' or 'auto' - default)", metavar="FMT", default="auto")
3434
parser.add_option("-m", "--metric", dest="metric", help="output metric", metavar="NAME", default="gmean")
35-
parser.add_option("-u", "--units", dest="units", help="units for output values (s, ms (default), mks, ns or ticks)", metavar="UNITS", default="ms")
35+
parser.add_option("-u", "--units", dest="units", help="units for output values (s, ms (default), us, ns or ticks)", metavar="UNITS", default="ms")
3636
parser.add_option("-f", "--filter", dest="filter", help="regex to filter tests", metavar="REGEX", default=None)
3737
parser.add_option("", "--module", dest="module", default=None, metavar="NAME", help="module prefix for test names")
3838
parser.add_option("", "--columns", dest="columns", default=None, metavar="NAMES", help="comma-separated list of column aliases")
@@ -46,6 +46,7 @@ def getSetName(tset, idx, columns, short = True):
4646
parser.add_option("", "--match-replace", dest="match_replace", default="")
4747
parser.add_option("", "--regressions-only", dest="regressionsOnly", default=None, metavar="X-FACTOR", help="show only tests with performance regressions not")
4848
parser.add_option("", "--intersect-logs", dest="intersect_logs", default=False, help="show only tests present in all log files")
49+
parser.add_option("", "--show_units", action="store_true", dest="show_units", help="append units into table cells")
4950
(options, args) = parser.parse_args()
5051

5152
options.generateHtml = detectHtmlOutputType(options.format)
@@ -75,6 +76,8 @@ def parseRegressionColumn(s):
7576

7677
options.regressions = [parseRegressionColumn(s) for s in options.regressions.split(',')]
7778

79+
show_units = options.units if options.show_units else None
80+
7881
# expand wildcards and filter duplicates
7982
files = []
8083
seen = set()
@@ -142,7 +145,7 @@ def parseRegressionColumn(s):
142145
getter_score = metrix_table["score"][1] if options.calc_score else None
143146
getter_p = metrix_table[options.metric + "%"][1] if options.calc_relatives else None
144147
getter_cr = metrix_table[options.metric + "$"][1] if options.calc_cr else None
145-
tbl = table(metrix_table[options.metric][0], options.format)
148+
tbl = table('%s (%s)' % (metrix_table[options.metric][0], options.units), options.format)
146149

147150
# header
148151
tbl.newColumn("name", "Name of Test", align = "left", cssclass = "col_name")
@@ -204,7 +207,7 @@ def addHeaderColumns(suffix, description, cssclass):
204207
val = getter(case, cases[0], options.units)
205208
if val:
206209
needNewRow = True
207-
tbl.newCell(str(i), formatValue(val, options.metric, options.units), val)
210+
tbl.newCell(str(i), formatValue(val, options.metric, show_units), val)
208211

209212
if needNewRow:
210213
for link in options.regressions:
@@ -253,12 +256,12 @@ def getRegression(fn):
253256
color = None
254257
if addColor:
255258
if not reverse:
256-
tbl.newCell(str(i), formatValue(val, options.metric, options.units), val, color=color)
259+
tbl.newCell(str(i), formatValue(val, options.metric, show_units), val, color=color)
257260
else:
258261
r = cases[reference]
259262
if r is not None and r.get("status") == 'run':
260263
val = getter(r, cases[0], options.units)
261-
tbl.newCell(str(reference), formatValue(val, options.metric, options.units), val, color=color)
264+
tbl.newCell(str(reference), formatValue(val, options.metric, show_units), val, color=color)
262265
if options.calc_relatives:
263266
tbl.newCell(tblCellID + "%", formatValue(valp, "%"), valp, color=color, bold=color)
264267
if options.calc_cr:

modules/ts/misc/table_formatter.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,10 @@ def formatValue(val, metric, units = None):
716716
if val > 0:
717717
return "slower"
718718
#return "%.4f" % val
719-
return "%.3f %s" % (val, units)
719+
if units:
720+
return "%.3f %s" % (val, units)
721+
else:
722+
return "%.3f" % val
720723

721724
if __name__ == "__main__":
722725
if len(sys.argv) < 2:
@@ -726,7 +729,7 @@ def formatValue(val, metric, units = None):
726729
parser = OptionParser()
727730
parser.add_option("-o", "--output", dest="format", help="output results in text format (can be 'txt', 'html', 'markdown' or 'auto' - default)", metavar="FMT", default="auto")
728731
parser.add_option("-m", "--metric", dest="metric", help="output metric", metavar="NAME", default="gmean")
729-
parser.add_option("-u", "--units", dest="units", help="units for output values (s, ms (default), mks, ns or ticks)", metavar="UNITS", default="ms")
732+
parser.add_option("-u", "--units", dest="units", help="units for output values (s, ms (default), us, ns or ticks)", metavar="UNITS", default="ms")
730733
(options, args) = parser.parse_args()
731734

732735
options.generateHtml = detectHtmlOutputType(options.format)

modules/ts/misc/testlog_parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def get(self, name, units="ms"):
9696
frequency = self.metrix.get("frequency", 1.0) or 1.0
9797
if units == "ms":
9898
scale = 1000.0
99-
if units == "mks":
99+
if units == "us" or units == "mks": # mks is typo error for microsecond (<= OpenCV 3.4)
100100
scale = 1000000.0
101101
if units == "ns":
102102
scale = 1000000000.0

0 commit comments

Comments
 (0)