Merge pull request #562 from artoonie/bugfix/fix-data-entry

fix data entry

Author: artoonie

static/datatable/src/model/candidate.ts

@@ -167,9 +167,13 @@ export default class Candidate {
             placeholder);
         candidateName.classList.add("candidate-name-input");
         // TODO -- disabled for now -- NOMODALEDIT
-        // const moreInfoButton = Candidate.getMoreInfoButton(editor, candidate,
-        //     cell, candidateName, success, cancel,
-        //     onRendered, editorParams);
+        // TODO -- getMoreInfoButton does more than create the button.
+        // Without constructing this, data entry does not work.
+        // 1. Split out whatever initialization is done here into something unrelated to "more info"
+        // 2. Add a regression test that catches this issue
+        const moreInfoButton = Candidate.getMoreInfoButton(editor, candidate,
+            cell, candidateName, success, cancel,
+            onRendered, editorParams);
         // editor.appendChild(document.createElement("br"));
         // editor.appendChild(moreInfoButton);
 

templates/settings/settings-upload-by-datatable.html

@@ -39,3 +39,5 @@
 <script src="https://code.jquery.com/jquery-3.5.1.min.js" integrity="sha256-9/aliU8dGd2tb6OSsuzixeV4y/faTqgFtohetphbbj0=" crossorigin="anonymous"></script>
 {% compress js file %}
 {% endcompress %}
+
+{% include "settings/settings-candidate-modal.html" %}