Skip to content

Commit a846b2e

Browse files
committed
Fixed news response, remove page params in rankings and other fixes to filter
1 parent f53ed50 commit a846b2e

File tree

5 files changed

+21
-17
lines changed

5 files changed

+21
-17
lines changed

src/main/kotlin/com/jeluchu/core/models/jikan/anime/AnimeData.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ data class AnimeData(
8282

8383
/**
8484
* Type of the anime.
85-
* @see AnimeType for the detail.
8685
*/
8786
@SerialName("type")
8887
val type: String? = "",

src/main/kotlin/com/jeluchu/features/anime/mappers/AnimeMappers.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,6 @@ fun documentToAnimeTopEntity(doc: Document) = AnimeTopEntity(
227227
airing = doc.getBooleanSafe("airing"),
228228
type = doc.getStringSafe("type"),
229229
subtype = doc.getStringSafe("subtype"),
230-
page = doc.getIntSafe("page"),
231230
)
232231

233232
fun documentToAnimeLastEpisodeEntity(doc: Document) = LastEpisodeData(
@@ -252,7 +251,6 @@ fun documentToMangaTopEntity(doc: Document) = MangaTopEntity(
252251
status = doc.getStringSafe("status"),
253252
type = doc.getStringSafe("type"),
254253
subtype = doc.getStringSafe("subtype"),
255-
page = doc.getIntSafe("page"),
256254
)
257255

258256
fun documentToPeopleTopEntity(doc: Document) = PeopleTopEntity(
@@ -262,7 +260,6 @@ fun documentToPeopleTopEntity(doc: Document) = PeopleTopEntity(
262260
familyName = doc.getStringSafe("familyName"),
263261
image = doc.getStringSafe("image"),
264262
birthday = doc.getStringSafe("birthday"),
265-
page = doc.getIntSafe("page"),
266263
top = doc.getStringSafe("top"),
267264
)
268265

@@ -272,7 +269,6 @@ fun documentToCharacterTopEntity(doc: Document) = CharacterTopEntity(
272269
nameKanji = doc.getStringSafe("nameKanji"),
273270
image = doc.getStringSafe("image"),
274271
top = doc.getStringSafe("top"),
275-
page = doc.getIntSafe("page"),
276272
)
277273

278274
fun documentToAnimeTypeEntity(doc: Document) = AnimeTypeEntity(

src/main/kotlin/com/jeluchu/features/anime/routes/AnimeRoutes.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@ fun Route.animeEndpoints(
1111
mongoDatabase: MongoDatabase,
1212
service: AnimeService = AnimeService(mongoDatabase),
1313
directoryService: DirectoryService = DirectoryService(mongoDatabase),
14-
) {
15-
route(Routes.ANIME) {
16-
getToJson(Routes.ID) { service.getAnimeByMalId(call) }
17-
getToJson(Routes.LAST_EPISODES) { service.getLastEpisodes(call) }
18-
}
14+
) = route(Routes.ANIME) {
15+
getToJson(Routes.ID) { service.getAnimeByMalId(call) }
16+
getToJson(Routes.LAST_EPISODES) { service.getLastEpisodes(call) }
1917

2018
route(Routes.DIRECTORY) {
2119
getToJson { service.getDirectory(call) }

src/main/kotlin/com/jeluchu/features/news/services/NewsService.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import com.jeluchu.core.utils.Collections
77
import com.jeluchu.core.utils.RssSources
88
import com.jeluchu.core.utils.RssUrls
99
import com.jeluchu.core.utils.parseDataToDocuments
10-
import com.jeluchu.features.anime.mappers.documentToAnimeTopEntity
1110
import com.jeluchu.features.news.mappers.documentToNewsEntity
1211
import com.jeluchu.features.news.mappers.toNews
1312
import com.jeluchu.features.news.models.NewEntity
@@ -58,7 +57,7 @@ class NewsService(
5857
.find()
5958
.toList()
6059

61-
val elements = animes.map { documentToAnimeTopEntity(it) }
60+
val elements = animes.map { documentToNewsEntity(it) }
6261
call.respond(HttpStatusCode.OK, Json.encodeToString(elements))
6362
}
6463
}
@@ -93,7 +92,7 @@ class NewsService(
9392
.find()
9493
.toList()
9594

96-
val elements = animes.map { documentToAnimeTopEntity(it) }
95+
val elements = animes.map { documentToNewsEntity(it) }
9796
call.respond(HttpStatusCode.OK, Json.encodeToString(elements))
9897
}
9998
}

src/main/kotlin/com/jeluchu/features/rankings/services/RankingsService.kt

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,13 @@ class RankingsService(
105105
call.respond(HttpStatusCode.OK, Json.encodeToString(paginationResponse))
106106
} else {
107107
val animes = animeRanking
108-
.find(Filters.eq("type", type.lowercase()))
108+
.find(
109+
Filters.and(
110+
Filters.eq("page", page),
111+
Filters.eq("type", type),
112+
Filters.eq("subtype", filter)
113+
)
114+
)
109115
.skip(skipCount)
110116
.limit(size)
111117
.toList()
@@ -182,7 +188,13 @@ class RankingsService(
182188
call.respond(HttpStatusCode.OK, Json.encodeToString(paginationResponse))
183189
} else {
184190
val mangas = mangaRanking
185-
.find(Filters.eq("type", type.lowercase()))
191+
.find(
192+
Filters.and(
193+
Filters.eq("page", page),
194+
Filters.eq("type", type),
195+
Filters.eq("subtype", filter)
196+
)
197+
)
186198
.skip(skipCount)
187199
.limit(size)
188200
.toList()
@@ -241,7 +253,7 @@ class RankingsService(
241253
call.respond(HttpStatusCode.OK, Json.encodeToString(paginationResponse))
242254
} else {
243255
val peoples = peopleRanking
244-
.find()
256+
.find(Filters.and(Filters.eq("page", page)))
245257
.skip(skipCount)
246258
.limit(size)
247259
.toList()
@@ -300,7 +312,7 @@ class RankingsService(
300312
call.respond(HttpStatusCode.OK, Json.encodeToString(paginationResponse))
301313
} else {
302314
val characters = characterRanking
303-
.find()
315+
.find(Filters.and(Filters.eq("page", page)))
304316
.skip(skipCount)
305317
.limit(size)
306318
.toList()

0 commit comments

Comments
 (0)