Skip to content

Commit 45c59f0

Browse files
javachemeta-codesync[bot]
authored andcommitted
Remove unneeded static_pointer_cast (facebook#54611)
Summary: Pull Request resolved: facebook#54611 No need for a shared_ptr copy here, as the lambda will not outlive the function scope. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D87480063 fbshipit-source-id: 6d7030ef523a5e15991032064ff979926db00451
1 parent fcd6303 commit 45c59f0

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

packages/react-native/React/Fabric/Mounting/ComponentViews/VirtualView/RCTVirtualViewComponentView.mm

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -330,9 +330,8 @@ - (void)dispatchAsyncModeChange:(VirtualViewEventEmitter::OnModeChange &)event
330330
return;
331331
}
332332

333-
std::shared_ptr<const VirtualViewEventEmitter> emitter =
334-
std::static_pointer_cast<const VirtualViewEventEmitter>(_eventEmitter);
335-
emitter->onModeChange(event);
333+
auto &emitter = static_cast<const VirtualViewEventEmitter &>(*_eventEmitter);
334+
emitter.onModeChange(event);
336335
}
337336

338337
- (void)dispatchSyncModeChange:(VirtualViewEventEmitter::OnModeChange &)event
@@ -341,13 +340,12 @@ - (void)dispatchSyncModeChange:(VirtualViewEventEmitter::OnModeChange &)event
341340
return;
342341
}
343342

344-
std::shared_ptr<const VirtualViewEventEmitter> emitter =
345-
std::static_pointer_cast<const VirtualViewEventEmitter>(_eventEmitter);
343+
auto &emitter = static_cast<const VirtualViewEventEmitter &>(*_eventEmitter);
346344

347345
// TODO: Move this into a custom event emitter. We had to duplicate the codegen code here from onModeChange in order
348346
// to dispatch synchronously and discrete.
349-
emitter->experimental_flushSync([&emitter, &event]() {
350-
emitter->dispatchEvent(
347+
emitter.experimental_flushSync([&emitter, &event]() {
348+
emitter.dispatchEvent(
351349
"modeChange",
352350
[event](jsi::Runtime &runtime) {
353351
auto payload = jsi::Object(runtime);

packages/react-native/React/Fabric/Mounting/ComponentViews/VirtualViewExperimental/RCTVirtualViewExperimentalComponentView.mm

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,8 @@ - (void)_dispatchAsyncModeChange:(VirtualViewEventEmitter::OnModeChange &)event
266266
return;
267267
}
268268

269-
std::shared_ptr<const VirtualViewEventEmitter> emitter =
270-
std::static_pointer_cast<const VirtualViewEventEmitter>(_eventEmitter);
271-
emitter->onModeChange(event);
269+
auto &emitter = static_cast<const VirtualViewEventEmitter &>(*_eventEmitter);
270+
emitter.onModeChange(event);
272271
}
273272

274273
- (void)_dispatchSyncModeChange:(VirtualViewEventEmitter::OnModeChange &)event
@@ -277,13 +276,12 @@ - (void)_dispatchSyncModeChange:(VirtualViewEventEmitter::OnModeChange &)event
277276
return;
278277
}
279278

280-
std::shared_ptr<const VirtualViewEventEmitter> emitter =
281-
std::static_pointer_cast<const VirtualViewEventEmitter>(_eventEmitter);
279+
auto &emitter = static_cast<const VirtualViewEventEmitter &>(*_eventEmitter);
282280

283281
// TODO: Move this into a custom event emitter. We had to duplicate the codegen code here from onModeChange in order
284282
// to dispatch synchronously and discrete.
285-
emitter->experimental_flushSync([&emitter, &event]() {
286-
emitter->dispatchEvent(
283+
emitter.experimental_flushSync([&emitter, &event]() {
284+
emitter.dispatchEvent(
287285
"modeChange",
288286
[event](jsi::Runtime &runtime) {
289287
auto payload = jsi::Object(runtime);

0 commit comments

Comments
 (0)