-
Notifications
You must be signed in to change notification settings - Fork 38
Open
Description
In areas like:
template <class NodeType, typename... Args>
SomeBuilder<Parent> leaf(Args... args)
{
auto child = std::make_shared<NodeType>((args)...);
node->setChild(child);
return *this;
}there needs to be forwarding to avoid unintended copying:
template <class NodeType, typename... Args>
SomeBuilder<Parent> leaf(Args&&... args)
{
auto child = std::make_shared<NodeType>(std::forward<Args>(args)...);
node->setChild(child);
return *this;
}Metadata
Metadata
Assignees
Labels
No labels