Skip to content

Commit 360697b

Browse files
Removed fill_last, contour and plot_kwargs arguments (#2085)
* removed fill_last, contour and plot_kwargs arguments * updated changelog * rephrase changelog description of PR
1 parent fd27b97 commit 360697b

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
* Change `ax.plot` usage to `ax.scatter` in `plot_pair` ([1990](https://github.com/arviz-devs/arviz/pull/1990))
1111

1212
### Deprecation
13+
* Removed `fill_last`, `contour` and `plot_kwargs` arguments from `plot_pair` function ([2085](https://github.com/arviz-devs/arviz/pull/2085))
1314

1415
### Documentation
1516
* Add translation overview to contributing guide ([2041](https://github.com/arviz-devs/arviz/pull/2041))

arviz/plots/pairplot.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ def plot_pair(
2424
textsize=None,
2525
kind: Union[str, List[str]] = "scatter",
2626
gridsize="auto",
27-
contour: Optional[bool] = None,
28-
plot_kwargs=None,
29-
fill_last=False,
3027
divergences=False,
3128
colorbar=False,
3229
labeller=None,
@@ -82,11 +79,6 @@ def plot_pair(
8279
such that the hexagons are approximately regular. Alternatively, gridsize
8380
can be a tuple with two elements specifying the number of hexagons
8481
in the x-direction and the y-direction.
85-
contour : bool, optional, deprecated, Defaults to True.
86-
If True plot the 2D KDE using contours, otherwise plot a smooth 2D KDE. Defaults to True.
87-
**Note:** this default is implemented in the body of the code, not in argument processing.
88-
fill_last : bool
89-
If True fill the last contour of the 2D KDE plot. Defaults to True.
9082
divergences: Boolean
9183
If True divergences will be plotted in a different color, only if group is either 'prior'
9284
or 'posterior'.
@@ -188,17 +180,6 @@ def plot_pair(
188180
kind_boolean = [kind[i] in valid_kinds for i in range(len(kind))]
189181
if not np.all(kind_boolean):
190182
raise ValueError(f"Plot type {kind} not recognized. Plot type must be in {valid_kinds}")
191-
if fill_last or contour:
192-
warnings.warn(
193-
"fill_last and contour will be deprecated. Please use kde_kwargs",
194-
UserWarning,
195-
)
196-
if plot_kwargs:
197-
warnings.warn(
198-
"plot_kwargs will be deprecated."
199-
" Please use scatter_kwargs, kde_kwargs and/or hexbin_kwargs",
200-
UserWarning,
201-
)
202183

203184
if coords is None:
204185
coords = {}

0 commit comments

Comments
 (0)