Race condition for daily warning?

[Zethson]

Describe the bug

tests/tools/_coda/test_sccoda.py:3: in <module>
    import arviz as az
../../../.local/share/hatch/env/virtual/pertpy/xQQBcIEI/hatch-test.py3.12/lib/python3.12/site-packages/arviz/__init__.py:61: in <module>
    _warn_once_per_day()
../../../.local/share/hatch/env/virtual/pertpy/xQQBcIEI/hatch-test.py3.12/lib/python3.12/site-packages/arviz/__init__.py:58: in _warn_once_per_day
    _atomic_write_text(stamp_file, today.isoformat())
../../../.local/share/hatch/env/virtual/pertpy/xQQBcIEI/hatch-test.py3.12/lib/python3.12/site-packages/arviz/__init__.py:36: in _atomic_write_text
    tmp.replace(path)
/usr/lib/python3.12/pathlib.py:1378: in replace
    os.replace(self, target)
E   FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/.cache/arviz/daily_warning.tmp' -> '/home/runner/.cache/arviz/daily_warning'

Expected behaviour

I would expect such a required folder to be silently created

Steps to reproduce

I have a CI setup where I run pytest with parallel workers. Up until recently, this was all fine but as of a few days or very few weeks ago, my CI regularly fails with the above message. My best guess is that there's a race condition going on.

I think the folder should always be properly created or something else is likely wrong with how the warning works.

Additional context

No response

[OriolAbril]

Thanks for reporting, we have already done a couple of improvements on the daily warning but not enough it seems. We'll look into this, maybe instead of a daily_warning.tmp we should have a unique temporal file every time it is created so different workers won't clash? cc @schmoelder who reported and improved the situation in the previous round. It might also be a good idea to use except Exception in that try except block to fall back to warning in any potential edge case that can happen ignoring the once a day condition.

@Zethson also note there is an immediate fix to ensure no warning happens and therefore there is no race condition or other issues regarding the warning which is installing arviz[preview]. This will install the refactored versions and avoid the warning and daily check altogether. I would even say this is the recommended course of action as it will allow getting started with the migration (even if some other dependencies haven't been able to fully migrate yet).