Skip to content

Commit 001d59c

Browse files
committed
refactor(dag): update some multi-parameter function argument names
1 parent 0228026 commit 001d59c

File tree

1 file changed

+15
-6
lines changed
  • git-branchless-lib/src/core

1 file changed

+15
-6
lines changed

git-branchless-lib/src/core/dag.rs

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -419,8 +419,13 @@ impl Dag {
419419

420420
/// Wrapper around DAG method.
421421
#[instrument]
422-
pub fn query_is_ancestor(&self, lhs: NonZeroOid, rhs: NonZeroOid) -> eden_dag::Result<bool> {
423-
let result = self.run_blocking(self.inner.is_ancestor(lhs.into(), rhs.into()))?;
422+
pub fn query_is_ancestor(
423+
&self,
424+
ancestor: NonZeroOid,
425+
descendant: NonZeroOid,
426+
) -> eden_dag::Result<bool> {
427+
let result =
428+
self.run_blocking(self.inner.is_ancestor(ancestor.into(), descendant.into()))?;
424429
Ok(result)
425430
}
426431

@@ -630,15 +635,19 @@ impl Dag {
630635

631636
/// Wrapper around DAG method.
632637
#[instrument]
633-
pub fn query_only(&self, from: CommitSet, to: CommitSet) -> eden_dag::Result<CommitSet> {
634-
let result = self.run_blocking(self.inner.only(from, to))?;
638+
pub fn query_only(
639+
&self,
640+
reachable: CommitSet,
641+
unreachable: CommitSet,
642+
) -> eden_dag::Result<CommitSet> {
643+
let result = self.run_blocking(self.inner.only(reachable, unreachable))?;
635644
Ok(result)
636645
}
637646

638647
/// Wrapper around DAG method.
639648
#[instrument]
640-
pub fn query_range(&self, from: CommitSet, to: CommitSet) -> eden_dag::Result<CommitSet> {
641-
let result = self.run_blocking(self.inner.range(from, to))?;
649+
pub fn query_range(&self, roots: CommitSet, heads: CommitSet) -> eden_dag::Result<CommitSet> {
650+
let result = self.run_blocking(self.inner.range(roots, heads))?;
642651
Ok(result)
643652
}
644653

0 commit comments

Comments
 (0)