refactor: Fix leak memory issues (#91)

* refactor: Fix leak memory issues

* wip refactor some code

* move smart pointer from the codegen visitors to new class

* Fix production files

* fix remaining errors

Author: xmnlab

.makim.yaml

@@ -25,13 +25,20 @@ groups:
         help: Build Arx for release
         env:
           ASAN_OPTIONS: '{{ args.asan_options }}'
+          LSAN_OPTIONS: '{{ args.lsan_options }}'
         args:
           asan-options:
             help: |
               Define a custom value for the environment variable
               `ASAN_OPTIONS`
             type: string
             default: ''
+          lsan-options:
+            help: |
+              Define a custom value for the environment variable
+              `LSAN_OPTIONS`
+            type: string
+            default: ''
           build-type:
             help: |
               Define the build type, options are:
@@ -49,6 +56,7 @@ groups:
         dependencies:
           - target: build.clean
             if: {{ args.clean }}
+        shell: bash
         run: |
           meson setup \
             --prefix $CONDA_PREFIX \
@@ -59,6 +67,22 @@ groups:
             build .
           meson compile -C build
 
+      debug:
+        help: Build for debugging (+debug)
+        args:
+          clean:
+            help: Clean temporary files before the building step
+            type: bool
+            action: store_true
+        dependencies:
+          - target: build.release
+            args:
+              build-type: "debug"
+              extras: "-Db_coverage=true -Doptimization=0"  # -Db_sanitize=address
+              clean: {{ args.clean }}
+              asan-options: "fast_unwind_on_malloc=0:verbosity=2:log_threads=1"
+              lsan-options: "fast_unwind_on_malloc=0:verbosity=2:log_threads=1"
+
       dev:
         help: Build for development (+tests +debug)
         args:
@@ -70,9 +94,10 @@ groups:
           - target: build.release
             args:
               build-type: "debug"
-              extras: "-Ddev=enabled -Db_coverage=true -Doptimization=0"
+              extras: "-Ddev=enabled -Db_coverage=true -Doptimization=0"  #  -Db_sanitize=address
               clean: {{ args.clean }}
-              asan-options: "fast_unwind_on_malloc=0"
+              asan-options: "fast_unwind_on_malloc=0:verbosity=2:log_threads=1"
+              lsan-options: "fast_unwind_on_malloc=0:verbosity=2:log_threads=1"
 
   env:
     targets:
@@ -82,7 +107,6 @@ groups:
           touch .env
           echo -n @("HOST_UID=" + $(id -u) + "HOST_GID=" + $(id -g)) > .env
 
-
   conda:
     targets:
       build:
@@ -92,7 +116,6 @@ groups:
           conda build purge
           conda mambabuild .
 
-
   release:
     vars:
       app: |
@@ -178,6 +201,10 @@ groups:
 
           GDB=""
           DEBUG_FLAGS=""
+          # another options: halt_on_error=true
+          # it could be a useful flag: -fsanitize-recover
+          export LSAN_OPTIONS=verbosity=2:log_threads=1
+          export ASAN_OPTIONS=verbosity=2:check_initialization_order=1:detect_leaks=1
 
           if [[ "{{ args.debug  }}" == "True" ]]; then
             GDB="gdb --args"

meson.build

@@ -47,6 +47,7 @@ inc = include_directories('./src')
 SRC_PATH = PROJECT_PATH + '/src'
 
 project_src_files = files(
+  SRC_PATH + '/codegen/arx-llvm.cpp',
   SRC_PATH + '/codegen/ast-to-llvm-ir.cpp',
   SRC_PATH + '/codegen/ast-to-object.cpp',
   SRC_PATH + '/codegen/ast-to-stdout.cpp',

src/codegen/arx-llvm.cpp

@@ -0,0 +1,24 @@
+
+#include <llvm/IR/DIBuilder.h>   // for DIBuilder
+#include <llvm/IR/IRBuilder.h>   // for IRBuilder
+#include <llvm/IR/Module.h>      // for Module
+#include <llvm/Support/Error.h>  // for ExitOnError
+
+#include "codegen/arx-llvm.h"  // for ArxLLVM
+#include "codegen/jit.h"       // for ArxJIT
+#include "parser.h"            // for ArxJIT
+
+std::unique_ptr<llvm::LLVMContext> ArxLLVM::context;
+std::unique_ptr<llvm::Module> ArxLLVM::module;
+std::unique_ptr<llvm::IRBuilder<>> ArxLLVM::ir_builder;
+std::unique_ptr<llvm::DIBuilder> ArxLLVM::di_builder;
+std::unique_ptr<llvm::orc::ArxJIT> ArxLLVM::jit;
+
+std::map<std::string, llvm::AllocaInst*> ArxLLVM::named_values;
+std::map<std::string, std::unique_ptr<PrototypeAST>> ArxLLVM::function_protos;
+
+/* Data types */
+llvm::Type* ArxLLVM::DOUBLE_TYPE;
+llvm::Type* ArxLLVM::FLOAT_TYPE;
+llvm::Type* ArxLLVM::INT8_TYPE;
+llvm::Type* ArxLLVM::INT32_TYPE;

src/codegen/arx-llvm.h

@@ -0,0 +1,27 @@
+#pragma once
+
+#include <llvm/IR/DIBuilder.h>   // for DIBuilder
+#include <llvm/IR/IRBuilder.h>   // for IRBuilder
+#include <llvm/IR/Module.h>      // for Module
+#include <llvm/Support/Error.h>  // for ExitOnError
+
+#include "codegen/jit.h"  // for ArxJIT
+#include "parser.h"       // for ArxJIT
+
+class ArxLLVM {
+ public:
+  static std::unique_ptr<llvm::LLVMContext> context;
+  static std::unique_ptr<llvm::Module> module;
+  static std::unique_ptr<llvm::IRBuilder<>> ir_builder;
+  static std::unique_ptr<llvm::DIBuilder> di_builder;
+  static std::unique_ptr<llvm::orc::ArxJIT> jit;
+
+  static std::map<std::string, llvm::AllocaInst*> named_values;
+  static std::map<std::string, std::unique_ptr<PrototypeAST>> function_protos;
+
+  /* Data types */
+  static llvm::Type* DOUBLE_TYPE;
+  static llvm::Type* FLOAT_TYPE;
+  static llvm::Type* INT8_TYPE;
+  static llvm::Type* INT32_TYPE;
+};