testando abordagem hibrida reviewdog

Author: anaalves-asaas

entrypoint.sh

@@ -1,25 +1,27 @@
 #!/bin/sh
 set -e
-trap 'cleanup_temp_files' EXIT
 
+# Constants
 CODENARC_RESULT="result.txt"
+LINE_VIOLATIONS="line_violations.txt"
+FILE_VIOLATIONS="file_violations.txt"
 VIOLATIONS_FLAG="/tmp/found_violations.txt"
 ALL_DIFF="/tmp/all_diff.txt"
 CHANGED_LINES_CACHE="/tmp/changed_lines.txt"
 CHANGED_FILES_CACHE="/tmp/changed_files.txt"
-TEMP_VIOLATIONS="/tmp/temp_violations.txt"
 
 cleanup_temp_files() {
-  rm -f "$CODENARC_RESULT" "$VIOLATIONS_FLAG" "$ALL_DIFF" "$CHANGED_LINES_CACHE" "$CHANGED_FILES_CACHE" "$TEMP_VIOLATIONS" >/dev/null 2>&1
+  rm -f "$CODENARC_RESULT" "$LINE_VIOLATIONS" "$FILE_VIOLATIONS" "$VIOLATIONS_FLAG" \
+        "$ALL_DIFF" "$CHANGED_LINES_CACHE" "$CHANGED_FILES_CACHE" >/dev/null 2>&1
 }
 
+trap 'cleanup_temp_files' EXIT
+
 run_codenarc() {
   report="${INPUT_REPORT:-compact:stdout}"
   includes_arg=""
 
-  if [ -n "$INPUT_SOURCE_FILES" ]; then
-    includes_arg="-includes=${INPUT_SOURCE_FILES}"
-  fi
+  [ -n "$INPUT_SOURCE_FILES" ] && includes_arg="-includes=${INPUT_SOURCE_FILES}"
 
   echo "🔍 Executando CodeNarc..."
   java -jar /lib/codenarc-all.jar \
@@ -30,52 +32,98 @@ run_codenarc() {
     > "$CODENARC_RESULT"
 }
 
+run_reviewdog_with_config() {
+  input_file="$1"
+  efm="$2"
+  reporter="$3"
+  name="$4"
+  filter_mode="$5"
+  level="$6"
+  
+  < "$input_file" reviewdog \
+    -efm="$efm" \
+    -reporter="$reporter" \
+    -name="$name" \
+    -filter-mode="$filter_mode" \
+    -fail-on-error="false" \
+    -level="$level" \
+    ${INPUT_REVIEWDOG_FLAGS} || true
+}
+
+separate_violations() {
+  grep -E ':[0-9]+:' "$CODENARC_RESULT" > "$LINE_VIOLATIONS" || true
+  grep -E ':null:|::' "$CODENARC_RESULT" > "$FILE_VIOLATIONS" || true
+}
+
 run_reviewdog() {
   echo "📤 Enviando resultados para reviewdog..."
-  < "$CODENARC_RESULT" reviewdog \
-    -efm="%f:%l:%m" -efm="%f:%r:%m" \
-    -name="codenarc" \
-    -reporter="${INPUT_REPORTER:-github-pr-check}" \
-    -filter-mode="${INPUT_FILTER_MODE}" \
-    -fail-on-error="${INPUT_FAIL_ON_ERROR}" \
-    -level="${INPUT_LEVEL}" \
-    ${INPUT_REVIEWDOG_FLAGS}
+  
+  separate_violations
+  
+  # Violações line-based com reporter configurado
+  if [ -s "$LINE_VIOLATIONS" ]; then
+    echo "📤 Enviando violações com linha (${INPUT_REPORTER:-github-pr-check})..."
+    run_reviewdog_with_config "$LINE_VIOLATIONS" "%f:%l:%m" \
+      "${INPUT_REPORTER:-github-pr-check}" "codenarc-lines" \
+      "${INPUT_FILTER_MODE}" "${INPUT_LEVEL}"
+  fi
+  
+  # Violações file-based forçando github-pr-check
+  if [ -s "$FILE_VIOLATIONS" ]; then
+    echo "📤 Enviando violações file-based (github-pr-check)..."
+    run_reviewdog_with_config "$FILE_VIOLATIONS" "%f::%m" \
+      "github-pr-check" "codenarc-files" "nofilter" "warning"
+  fi
+  
+  # Fallback se não houver violações categorizadas
+  if [ ! -s "$LINE_VIOLATIONS" ] && [ ! -s "$FILE_VIOLATIONS" ]; then
+    echo "📝 Executando reviewdog padrão..."
+    run_reviewdog_with_config "$CODENARC_RESULT" "%f:%l:%m" \
+      "${INPUT_REPORTER:-github-pr-check}" "codenarc" \
+      "${INPUT_FILTER_MODE}" "${INPUT_LEVEL}"
+  fi
 }
 
-generate_all_diff() {
+generate_git_diff() {
   if [ -n "$GITHUB_BASE_SHA" ] && [ -n "$GITHUB_HEAD_SHA" ]; then
     git fetch origin "$GITHUB_BASE_SHA" --depth=1 2>/dev/null || true
     git fetch origin "$GITHUB_HEAD_SHA" --depth=1 2>/dev/null || true
-    git diff -U0 "$GITHUB_BASE_SHA" "$GITHUB_HEAD_SHA" -- '*.groovy' > "$ALL_DIFF" 2>/dev/null || true
+    git diff -U0 "$GITHUB_BASE_SHA" "$GITHUB_HEAD_SHA" -- '*.groovy'
+  else
+    git diff -U0 HEAD~1 -- '*.groovy'
+  fi
+}
+
+parse_diff_range() {
+  range="$1"
+  if echo "$range" | grep -q ","; then
+    echo "$(echo "$range" | cut -d',' -f1) $(echo "$range" | cut -d',' -f2)"
   else
-    git diff -U0 HEAD~1 -- '*.groovy' > "$ALL_DIFF" 2>/dev/null || true
+    echo "$range 1"
   fi
 }
 
 build_changed_lines_cache() {
   true > "$CHANGED_LINES_CACHE"
   true > "$CHANGED_FILES_CACHE"
-  current_file=""
 
+  generate_git_diff > "$ALL_DIFF" 2>/dev/null || true
   [ ! -s "$ALL_DIFF" ] && return 0
 
+  current_file=""
   while read -r line; do
-    if echo "$line" | grep -q "^diff --git"; then
-      current_file=$(echo "$line" | sed 's|^diff --git a/\(.*\) b/.*|\1|')
-      if [ -n "$current_file" ]; then
-        echo "$current_file" >> "$CHANGED_FILES_CACHE"
-      fi
-    elif echo "$line" | grep -q "^@@"; then
-      if [ -n "$current_file" ]; then
+    case "$line" in
+      "diff --git"*)
+        current_file=$(echo "$line" | sed 's|^diff --git a/\(.*\) b/.*|\1|')
+        [ -n "$current_file" ] && echo "$current_file" >> "$CHANGED_FILES_CACHE"
+        ;;
+      "@@"*)
+        [ -z "$current_file" ] && continue
         range=$(echo "$line" | sed 's/.*+\([0-9,]*\).*/\1/')
-        if echo "$range" | grep -q ","; then
-          start=$(echo "$range" | cut -d',' -f1)
-          count=$(echo "$range" | cut -d',' -f2)
-        else
-          start="$range"
-          count=1
-        fi
-
+        range_info=$(parse_diff_range "$range")
+        start=$(echo "$range_info" | cut -d' ' -f1)
+        count=$(echo "$range_info" | cut -d' ' -f2)
+        
         case "$start" in ''|*[!0-9]*) continue ;; esac
         case "$count" in ''|*[!0-9]*) continue ;; esac
 
@@ -84,17 +132,17 @@ build_changed_lines_cache() {
           echo "$current_file:$i" >> "$CHANGED_LINES_CACHE"
           i=$((i + 1))
         done
-      fi
-    fi
+        ;;
+    esac
   done < "$ALL_DIFF"
 }
 
-get_p1_violations_count() {
+get_p1_count() {
   p1_count=$(grep -Eo "p1=[0-9]+" "$CODENARC_RESULT" | cut -d'=' -f2 | head -1)
   echo "${p1_count:-0}"
 }
 
-parse_allowed_file_patterns() {
+get_allowed_patterns() {
   [ -n "$INPUT_SOURCE_FILES" ] && echo "$INPUT_SOURCE_FILES" | tr ',' '\n' | sed 's/\*\*/.*/g'
 }
 
@@ -105,77 +153,53 @@ file_matches_patterns() {
   [ -z "$patterns" ] && return 0
 
   for pattern in $patterns; do
-    if echo "$file" | grep -Eq "$pattern"; then
-      return 0
-    fi
+    echo "$file" | grep -Eq "$pattern" && return 0
   done
-  
   return 1
 }
 
-line_is_in_changed_range() {
-  target_line="$1"
-  file="$2"
-  
-  grep -q "^$file:$target_line$" "$CHANGED_LINES_CACHE"
+is_line_changed() {
+  grep -q "^$2:$1$" "$CHANGED_LINES_CACHE"
 }
 
-file_was_changed() {
-  file="$1"
-  grep -q "^$file$" "$CHANGED_FILES_CACHE"
+is_file_changed() {
+  grep -q "^$1$" "$CHANGED_FILES_CACHE"
 }
 
 check_blocking_rules() {
   echo "🔎 Verificando violações bloqueantes (priority 1)..."
 
-  [ ! -f "$CODENARC_RESULT" ] && echo "❌ Arquivo de resultado não encontrado" && return 1
+  [ ! -f "$CODENARC_RESULT" ] && echo "❌ Resultado não encontrado" && return 1
 
-  p1_count=$(get_p1_violations_count)
-  echo "📊 Total de P1 encontradas: $p1_count"
+  p1_count=$(get_p1_count)
+  echo "📊 Total de P1: $p1_count"
 
-  if [ "$p1_count" -eq 0 ]; then
-    echo "✅ Nenhuma P1 detectada → merge permitido (análise de diff desnecessária)"
-    return 0
-  fi
+  [ "$p1_count" -eq 0 ] && echo "✅ Nenhuma P1 → merge permitido" && return 0
 
-  echo "⚠️  P1s detectadas → verificando se estão em linhas alteradas..."
-  generate_all_diff
+  echo "⚠️  Verificando P1s em linhas alteradas..."
   build_changed_lines_cache
 
-  allowed_patterns=$(parse_allowed_file_patterns)
-  if [ -n "$allowed_patterns" ]; then
-    echo "🧩 Analisando apenas arquivos filtrados por INPUT_SOURCE_FILES"
-  fi
+  allowed_patterns=$(get_allowed_patterns)
+  [ -n "$allowed_patterns" ] && echo "🧩 Filtrando por INPUT_SOURCE_FILES"
 
   echo "0" > "$VIOLATIONS_FLAG"
 
-  grep -E ':[0-9]+:|:[0-9]*:' "$CODENARC_RESULT" > "$TEMP_VIOLATIONS"
-  
-  [ ! -s "$TEMP_VIOLATIONS" ] && echo "✅ Nenhuma violação encontrada no resultado" && return 0
-  
-  while IFS=: read -r file line rest; do
+  grep -E ':[0-9]+:|:null:|\|\|' "$CODENARC_RESULT" | while IFS=: read -r file line rest; do
     [ -z "$file" ] && continue
-    
-    if ! file_matches_patterns "$file" "$allowed_patterns"; then
-      continue
-    fi
+    file_matches_patterns "$file" "$allowed_patterns" || continue
 
     if [ -z "$line" ] || [ "$line" = "null" ]; then
-      if file_was_changed "$file"; then
+      if is_file_changed "$file"; then
         echo "📍 Violação file-based em arquivo alterado: $file"
-        echo "1" > "$VIOLATIONS_FLAG"
-        break
+        echo "1" > "$VIOLATIONS_FLAG" && break
       fi
-    elif line_is_in_changed_range "$line" "$file"; then
+    elif is_line_changed "$line" "$file"; then
       echo "📍 Violação em linha alterada: $file:$line"
-      echo "1" > "$VIOLATIONS_FLAG"
-      break
+      echo "1" > "$VIOLATIONS_FLAG" && break
     fi
-  done < "$TEMP_VIOLATIONS"
-  
-  violations_in_diff=$(cat "$VIOLATIONS_FLAG")
+  done
 
-  if [ "$violations_in_diff" -eq 1 ]; then
+  if [ "$(cat "$VIOLATIONS_FLAG")" -eq 1 ]; then
     echo "⛔ P1s existem E há violações em linhas alteradas → DEVERIA bloquear merge"
     echo "🔧 Exit desabilitado temporariamente para monitoramento"
     # exit 1
@@ -184,15 +208,17 @@ check_blocking_rules() {
   fi
 }
 
+# Setup
 if [ -n "${GITHUB_WORKSPACE}" ]; then
   cd "${GITHUB_WORKSPACE}/${INPUT_WORKDIR}" || exit
   git config --global --add safe.directory "$GITHUB_WORKSPACE"
 fi
 
 export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}"
 
+# Execute pipeline
 run_codenarc
 run_reviewdog
 check_blocking_rules
 
-echo "🏁 Concluído com sucesso"
+echo "🏁 Concluído com sucesso"