Skip to content

Commit 8509d11

Browse files
DAlperinasabaylus
andauthored
Bug: don't invoke this.focusInput in mousetrap callback (#1157)
* Don't invoke this.focusInput in moustrap callback When calling this.focusInput() in the moustrap callback it is possible for this.commandPaletteInput.input to be null since this.commandPaletteInput is set during the render which is not guaranteed to happen first. This creates a race condition that can lead to an error being logged on the console in some cases. this.focusInput() is still called by afterOpenModal and thus the desired effect is acheived. * update snapshot Co-authored-by: Asa Baylus <[email protected]>
1 parent 928c917 commit 8509d11

File tree

2 files changed

+20
-465
lines changed

2 files changed

+20
-465
lines changed

0 commit comments

Comments
 (0)