Skip to content

Commit 14f4d0e

Browse files
ToddKingMSFTAndrew Sager
authored andcommitted
[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-01-01 (Azure#14716)
* Update metrics_API.json Fix lint errors, adopt the standard error response object, fix inconsistencies between swagger and real service flagged by S360 * Update GetMetricDefinitions.json Add error case to example * Update metricDefinitions_API.json Fix lint errors * Update readme.md Add lint suppression for errors in the common types file * Update metrics_API.json Update swagger to reflect what is actually being returned by the service as flagged by S360 * Create GetMetricError.json Add example of partial error case * Create GetMetricDefinitionsMetricClass.json Add example for metric definitions for metricClass * Update metricDefinitions_API.json Add metricClass field * Update metricDefinitions_API.json Switch back to the same error response format used by the rest of Azure Monitor * Update metrics_API.json Switch back to the same error response format used by the rest of Azure Monitor * Update readme.md Update suppressions * Update baseline_API.json Add type object to LocalizableString to match the LocalizableString in metrics * Update baseline_API.json Reverting change to baseline API, there are a number of other problems with this swagger that I can't fix. * Update readme.md Add suppression for MissingTypeObject on LocalizableString due to collision * Update metricDefinitions_API.json Removing the explicit type specification from LocalizableString so it continues to match other APIs * Update metrics_API.json Removing the explicit type specification from LocalizableString so it continues to match other APIs * Update GetMetricDefinitionsMetricClass.json Fix formatting problems
1 parent 4c54595 commit 14f4d0e

File tree

7 files changed

+1434
-23
lines changed

7 files changed

+1434
-23
lines changed

specification/monitor/resource-manager/Microsoft.Insights/preview/2017-05-01-preview/metrics_API.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,10 @@
319319
"type": "string",
320320
"description": "'Success' or the error details on query failures for this metric."
321321
},
322+
"errorMessage": {
323+
"type": "string",
324+
"description": "Error message encountered querying this specific metric."
325+
},
322326
"unit": {
323327
"$ref": "#/definitions/Unit",
324328
"description": "the unit of the metric."
@@ -335,7 +339,6 @@
335339
"id",
336340
"type",
337341
"name",
338-
"displayDescription",
339342
"unit",
340343
"timeseries"
341344
],

specification/monitor/resource-manager/Microsoft.Insights/stable/2018-01-01/examples/GetMetricDefinitions.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -970,6 +970,12 @@
970970
}
971971
]
972972
}
973+
},
974+
"default": {
975+
"body": {
976+
"code": "BadRequest",
977+
"message": "ApiVersion: 2018-01-01 does not support query metricdefinitions at non Arm resource Id level"
978+
}
973979
}
974980
}
975981
}

0 commit comments

Comments
 (0)