Skip to content

Commit 0d765df

Browse files
committed
Add easy build and execution instructions for developers
1 parent 5648eb1 commit 0d765df

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ We welcome any type of contribution, not only code. You can help with
1515

1616
Working on your first Pull Request? You can learn how from this *free* series, [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github).
1717

18+
## Getting started with the code
19+
20+
To start development of a new feature or fix, check out the repository with Git and start editing the code in your favorite IDE.
21+
22+
Once you're done editing, you will need a Java 16 JDK as well as Maven to build and run the code. Ensure that your `JAVA_HOME` is set to your Java 16 JDK path and run the following command to build and execute Asciidocfx : `mvn clean javafx:run -Djavafx.scope=compile`
23+
1824
## Submitting code
1925

2026
Any code change should be submitted as a pull request. The description should explain what the code does and give steps to execute it. The pull request should also contain tests.

pom.xml

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
<properties>
1414
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
15+
<asciidocfx.mainClass>com.kodedu.boot.AppStarter</asciidocfx.mainClass>
1516
<java.version>16</java.version>
1617
<maven.compiler.source>${java.version}</maven.compiler.source>
1718
<maven.compiler.target>${java.version}</maven.compiler.target>
@@ -21,6 +22,7 @@
2122
<openjfx.version>16</openjfx.version>
2223
<ikonli.version>12.2.0</ikonli.version>
2324
<jaxb.version>2.3.2</jaxb.version>
25+
<javafx.scope>provided</javafx.scope>
2426
</properties>
2527

2628
<organization>
@@ -222,25 +224,25 @@
222224
<groupId>org.openjfx</groupId>
223225
<artifactId>javafx-swing</artifactId>
224226
<version>${openjfx.version}</version>
225-
<scope>provided</scope>
227+
<scope>${javafx.scope}</scope>
226228
</dependency>
227229
<dependency>
228230
<groupId>org.openjfx</groupId>
229231
<artifactId>javafx-controls</artifactId>
230232
<version>${openjfx.version}</version>
231-
<scope>provided</scope>
233+
<scope>${javafx.scope}</scope>
232234
</dependency>
233235
<dependency>
234236
<groupId>org.openjfx</groupId>
235237
<artifactId>javafx-web</artifactId>
236238
<version>${openjfx.version}</version>
237-
<scope>provided</scope>
239+
<scope>${javafx.scope}</scope>
238240
</dependency>
239241
<dependency>
240242
<groupId>org.openjfx</groupId>
241243
<artifactId>javafx-fxml</artifactId>
242244
<version>${openjfx.version}</version>
243-
<scope>provided</scope>
245+
<scope>${javafx.scope}</scope>
244246
</dependency>
245247

246248
</dependencies>
@@ -288,7 +290,7 @@
288290
<configuration>
289291
<programs>
290292
<program>
291-
<mainClass>com.kodedu.boot.AppStarter</mainClass>
293+
<mainClass>${asciidocfx.mainClass}</mainClass>
292294
<id>asciidocfx</id>
293295
</program>
294296
</programs>
@@ -430,6 +432,14 @@
430432
</execution>
431433
</executions>
432434
</plugin>
435+
<plugin>
436+
<groupId>org.openjfx</groupId>
437+
<artifactId>javafx-maven-plugin</artifactId>
438+
<version>0.0.6</version>
439+
<configuration>
440+
<mainClass>${asciidocfx.mainClass}</mainClass>
441+
</configuration>
442+
</plugin>
433443
</plugins>
434444
</build>
435445

0 commit comments

Comments
 (0)