Skip to content

Commit 50662e2

Browse files
authored
define CSS filters for icons in vars (PR #78)
1 parent 2469bb6 commit 50662e2

File tree

6 files changed

+14
-8
lines changed

6 files changed

+14
-8
lines changed

src/css/doc.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ h1.page + aside.toc.embedded {
130130
.doc i.fa {
131131
display: inline-block;
132132
background: no-repeat center / 1em 1em;
133-
filter: invert(20%);
133+
filter: var(--doc-icon-filter);
134134
hyphens: none;
135135
font-style: normal;
136136
height: 1em;
@@ -746,7 +746,7 @@ h1.page + aside.toc.embedded {
746746
}
747747

748748
.doc .source-toolbox img.copy-icon {
749-
filter: invert(50.2%);
749+
filter: var(--pre-annotation-icon-filter);
750750
}
751751

752752
.doc .source-toolbox svg.copy-icon {

src/css/header.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ body {
183183
}
184184

185185
.navbar-item .icon img {
186-
filter: invert(10%);
186+
filter: var(--navbar-menu-icon-filter);
187187
}
188188

189189
.navbar-item .icon svg {

src/css/nav.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@
229229
.nav-panel-explore:not(:first-child) .context .version::after {
230230
content: "";
231231
background: url(../img/octicons-16.svg#view-chevron-down) no-repeat center right -0.15em / 1em 1em;
232-
filter: invert(36.5%); /* NOTE should match --color-gray-70 */
232+
filter: var(--nav-muted-icon-filter);
233233
padding-right: 1.25em;
234234
margin-right: -0.25rem;
235235
}

src/css/page-versions.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
.page-versions .version-menu-toggle::after {
2525
content: "";
2626
background: url(../img/octicons-16.svg#view-chevron-down) no-repeat center right -0.15em / 1em 1em;
27-
filter: invert(36.5%); /* NOTE should match --color-gray-70 */
27+
filter: var(--toolbar-icon-filter);
2828
padding-right: 1rem;
2929
}
3030

src/css/toolbar.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
.nav-toggle {
2020
background: url(../img/octicons-24.svg#view-file-directory) no-repeat center / 50% 50%;
21-
filter: invert(10%); /* NOTE should match --navbar-background */
21+
filter: var(--toolbar-primary-icon-filter);
2222
border: none;
2323
outline: none;
2424
line-height: inherit;
@@ -45,7 +45,7 @@
4545
width: calc(var(--toolbar-height) / 2);
4646
margin: calc(var(--toolbar-height) / 4);
4747
margin-right: 0.5rem;
48-
filter: invert(10%); /* NOTE should match --navbar-background */
48+
filter: var(--toolbar-primary-icon-filter);
4949
}
5050

5151
.home-link:hover,

src/css/vars.css

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,23 @@
5050
--navbar-menu-box-shadow: 0 2px 4px rgba(160, 160, 160, 0.15);
5151
--navbar-menu-background: var(--color-white);
5252
--navbar-menu-font-color: var(--body-font-color);
53+
--navbar-menu-icon-filter: invert(10%); /* matches --color-jet-80 */
5354
--navbar-menu_hover-background: var(--color-smoke-50);
5455
/* nav */
5556
--nav-background: var(--panel-background);
5657
--nav-border-color: var(--color-gray-10);
5758
--nav-line-height: 1.35;
5859
--nav-heading-font-color: var(--color-brand-primary);
5960
--nav-muted-color: var(--color-gray-70);
61+
--nav-muted-icon-filter: invert(36.5%); /* matches --color-gray-70 */
6062
--nav-panel-divider-color: var(--color-smoke-90);
6163
--nav-secondary-background: var(--color-smoke-70);
6264
/* toolbar */
6365
--toolbar-background: var(--panel-background);
6466
--toolbar-border-color: var(--panel-border-color);
65-
--toolbar-font-color: var(--color-gray-70);
67+
--toolbar-font-color: var(--nav-muted-color);
68+
--toolbar-icon-filter: var(--nav-muted-icon-filter);
69+
--toolbar-primary-icon-filter: var(--navbar-menu-icon-filter);
6670
--toolbar-muted-color: var(--color-gray-30);
6771
--page-version-menu-background: var(--color-smoke-70);
6872
--page-version-missing-font-color: var(--color-gray-30);
@@ -83,6 +87,7 @@
8387
--doc-font-color: #24292e;
8488
*/
8589
--doc-font-color: #24262b;
90+
--doc-icon-filter: invert(14.5%); /* matches #242424 */
8691
--doc-font-size: inherit;
8792
--doc-font-size--desktop: calc(17 / var(--rem-base) * 1rem);
8893
--doc-line-height: 1.6;
@@ -117,6 +122,7 @@
117122
--pre-background: var(--panel-background);
118123
--pre-border-color: var(--panel-border-color);
119124
--pre-annotation-font-color: var(--color-gray-50);
125+
--pre-annotation-icon-filter: invert(50.2%); /* matches --color-gray-50 */
120126
--quote-background: var(--panel-background);
121127
--quote-border-color: var(--color-gray-70);
122128
--quote-font-color: var(--color-gray-70);

0 commit comments

Comments
 (0)