Skip to content

Commit 758941d

Browse files
committed
resolve link for nav item inside scrollItemToMidpoint function
1 parent 3a65898 commit 758941d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/js/01-nav.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
var originalPageItem = currentPageItem
1818
if (currentPageItem) {
1919
activateCurrentPath(currentPageItem)
20-
scrollItemToMidpoint(menuPanel, currentPageItem.querySelector('.nav-link'))
20+
scrollItemToMidpoint(menuPanel, currentPageItem)
2121
} else {
2222
menuPanel.scrollTop = 0
2323
}
@@ -29,7 +29,7 @@
2929
})
3030
if (currentPageItem) {
3131
if (collapse) activateCurrentPath(currentPageItem, false)
32-
scrollItemToMidpoint(menuPanel, currentPageItem.querySelector('.nav-link'))
32+
scrollItemToMidpoint(menuPanel, currentPageItem)
3333
} else if (collapse) {
3434
menuPanel.scrollTop = 0
3535
}
@@ -89,7 +89,7 @@
8989
})
9090
;(currentPageItem = navItem).classList.add('is-current-page')
9191
activateCurrentPath(currentPageItem)
92-
scrollItemToMidpoint(menuPanel, navLink)
92+
scrollItemToMidpoint(menuPanel, currentPageItem)
9393
}
9494

9595
if (menuPanel.querySelector('.nav-link[href^="#"]')) {
@@ -153,7 +153,7 @@
153153
function scrollItemToMidpoint (panel, item) {
154154
if (panel.scrollHeight === panel.clientHeight) return // not scrollable
155155
var panelRect = panel.getBoundingClientRect()
156-
var linkRect = item.getBoundingClientRect()
156+
var linkRect = item.querySelector('.nav-link').getBoundingClientRect()
157157
panel.scrollTop += Math.round(linkRect.top - panelRect.top - (panelRect.height - linkRect.height) * 0.5)
158158
}
159159

0 commit comments

Comments
 (0)