resolves #88 assign height to nav container in desktop view and configure nav to inherit height (PR #89)

mojavelinux · web-flow · commit 872c7b37d1eb · 2021-01-15T02:42:59.000-07:00
diff --git a/src/css/nav.css b/src/css/nav.css
@@ -33,8 +33,8 @@
     font-size: calc(15.5 / var(--rem-base) * 1rem);
     flex: none;
     position: static;
-    top: 0;
     visibility: visible;
+    height: var(--nav-height--desktop);
   }
 }
 
@@ -57,11 +57,11 @@
 
 @media screen and (min-width: 1024px) {
   .nav {
-    top: var(--navbar-height);
+    top: var(--navbar-height); /* fixed position is relative to viewport */
     box-shadow: none;
     position: fixed;
-    height: var(--nav-height--desktop);
     width: inherit;
+    height: inherit;
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,8 @@`
`33`	`33`	`font-size: calc(15.5 / var(--rem-base) * 1rem);`
`34`	`34`	`flex: none;`
`35`	`35`	`position: static;`
`36`		`- top: 0;`
`37`	`36`	`visibility: visible;`
	`37`	`+ height: var(--nav-height--desktop);`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`
`@@ -57,11 +57,11 @@`
`57`	`57`
`58`	`58`	`@media screen and (min-width: 1024px) {`
`59`	`59`	`.nav {`
`60`		`- top: var(--navbar-height);`
	`60`	`+ top: var(--navbar-height); /* fixed position is relative to viewport */`
`61`	`61`	`box-shadow: none;`
`62`	`62`	`position: fixed;`
`63`		`- height: var(--nav-height--desktop);`
`64`	`63`	`width: inherit;`
	`64`	`+ height: inherit;`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`