Skip to content

Commit 9188a51

Browse files
committed
consistently add is-active as final class on tag; consolidate logic
1 parent 46b4c8a commit 9188a51

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/js/01-nav.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,10 @@
8787
}
8888
if (navItem === currentPageItem) return
8989
find(menuPanel, '.nav-item.is-active').forEach(function (el) {
90-
el.classList.remove('is-active', 'is-current-path', 'is-current-page')
90+
el.classList.remove('is-current-path', 'is-current-page', 'is-active')
9191
})
92-
navItem.classList.add('is-current-page')
93-
currentPageItem = navItem
94-
activateCurrentPath(navItem)
92+
;(currentPageItem = navItem).classList.add('is-current-page')
93+
activateCurrentPath(currentPageItem)
9594
scrollItemToMidpoint(menuPanel, navLink)
9695
}
9796

@@ -105,8 +104,8 @@
105104
var ancestor = navItem.parentNode
106105
while (!(ancestorClasses = ancestor.classList).contains('nav-menu')) {
107106
if (ancestor.tagName === 'LI' && ancestorClasses.contains('nav-item')) {
108-
ancestorClasses.add('is-active')
109107
if (trace !== false) ancestorClasses.add('is-current-path')
108+
ancestorClasses.add('is-active')
110109
}
111110
ancestor = ancestor.parentNode
112111
}

0 commit comments

Comments
 (0)