replace String#substr with String#slice and configure lint rule to enforce

Author: mojavelinux

.eslintrc

@@ -8,6 +8,10 @@
       "imports": "always-multiline",
       "exports": "always-multiline"
     }],
+    "no-restricted-properties": ["error", {
+      "property": "substr",
+      "message": "Use String#slice instead."
+    }],
     "max-len": [1, 120, 2],
     "spaced-comment": "off"
   }

gulp.d/tasks/build-preview-pages.js

@@ -44,7 +44,7 @@ module.exports =
                   uiModel.page.attributes = Object.entries(doc.getAttributes())
                     .filter(([name, val]) => name.startsWith('page-'))
                     .reduce((accum, [name, val]) => {
-                      accum[name.substr(5)] = val
+                      accum[name.slice(5)] = val
                       return accum
                     }, {})
                   uiModel.page.layout = doc.getAttribute('page-layout', 'default')
@@ -123,8 +123,8 @@ function relativize (to, { data: { root } }) {
   let hash = ''
   const hashIdx = to.indexOf('#')
   if (~hashIdx) {
-    hash = to.substr(hashIdx)
-    to = to.substr(0, hashIdx)
+    hash = to.slice(hashIdx)
+    to = to.slice(0, hashIdx)
   }
   return to === from
     ? hash || (to.charAt(to.length - 1) === '/' ? './' : path.basename(to))
@@ -143,7 +143,7 @@ function transformHandlebarsError ({ message, stack }, layout) {
   const m = stack.match(/^ *at Object\.ret \[as (.+?)\]/m)
   const templatePath = `src/${m ? 'partials/' + m[1] : 'layouts/' + layout}.hbs`
   const err = new Error(`${message}${~message.indexOf('\n') ? '\n^ ' : ' '}in UI template ${templatePath}`)
-  err.stack = [err.toString()].concat(stack.substr(message.length + 8)).join('\n')
+  err.stack = [err.toString()].concat(stack.slice(message.length + 8)).join('\n')
   return err
 }
 

gulp.d/tasks/build.js

@@ -39,7 +39,7 @@ module.exports = (src, dest, preview) => () => {
       {
         filter: (asset) => new RegExp('^[~][^/]*(?:font|typeface)[^/]*/.*/files/.+[.](?:ttf|woff2?)$').test(asset.url),
         url: (asset) => {
-          const relpath = asset.pathname.substr(1)
+          const relpath = asset.pathname.slice(1)
           const abspath = require.resolve(relpath)
           const basename = ospath.basename(abspath)
           const destpath = ospath.join(dest, 'font', basename)

gulp.d/tasks/index.js

@@ -1,5 +1,5 @@
 'use strict'
 
-const camelCase = (name) => name.replace(/[-]./g, (m) => m.substr(1).toUpperCase())
+const camelCase = (name) => name.replace(/[-]./g, (m) => m.slice(1).toUpperCase())
 
 module.exports = require('require-directory')(module, __dirname, { recurse: false, rename: camelCase })

src/helpers/rearrange.js

@@ -8,7 +8,7 @@ module.exports = (collection, property, orderSpec) => {
     .map((it) => it.trim())
     .filter((it) => {
       if (it.charAt() !== '!') return true
-      sourceCollection.delete(it.substr(1))
+      sourceCollection.delete(it.slice(1))
     })
   const restIdx = order.indexOf('*')
   if (~restIdx) order.splice(restIdx, 1)