Footer contains link to external OpenDevise Logo

[sdavids]

This could be used for tracking…

asciidoctor-docs-ui/src/partials/footer-content.hbs

Line 28 in 763fd8c

<a href="https://opendevise.com" title="Development support by OpenDevise" target="_blank" rel="noopener"><img src="https://secure.gravatar.com/avatar/823717a797dbd78ceff7b26aa397f383.png?size=80" alt="OpenDevise Logo" width="30"></a>

The image should be part of the ui bundle in docs/ui-bundle/img.

[mojavelinux]

That seems like a reasonable request. If you'd like to submit a PR with this change, I'll review/merge it.

[sdavids]

I just looked at the other images…

Should I run them through ImageOptim to minimise them?

$ du -kh src/img
544K    src/img

After minimising the *.svg files:

$ du -kh src/img
520K    src/img

After minimising the *.png file:

$ du -kh src/img
432K    src/img

[sdavids]

asciidoctor-og.png could/should be converted to an SVG as well.

[mojavelinux]

The build minimizes the images.

…

On Mon, Sep 30, 2024, 04:20 Sebastian Davids ***@***.***> wrote: asciidoctor-og.png could/should be converted to an SVG as well. — Reply to this email directly, view it on GitHub <#134 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAATL56JXL6YDSSSBTUUQHTZZEQWXAVCNFSM6AAAAABPC2V2M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBSG4YTKNBSGE> . You are receiving this because you commented.Message ID: ***@***.***>

[sdavids]

The build minimizes the images.

🤔

$ mkdir /tmp/test && cd "$_"
$ curl -sLO https://github.com/asciidoctor/asciidoctor-docs-ui/releases/download/prod-347/ui-bundle.zip
$ unzip ui-bundle.zip
$ cd img
$ du -kh .
452K
$ open -a ImageOptim *.svg *.png
$ du -kh .
416K

[mojavelinux]

Different minimizers may work better than others. I assure you the build for the UI does minimize images. I want the original image in the git repository.

…

On Mon, Sep 30, 2024, 04:43 Sebastian Davids ***@***.***> wrote: The build minimizes the images. 🤔 $ mkdir /tmp/test && cd "$_" $ curl -sLO https://github.com/asciidoctor/asciidoctor-docs-ui/releases/download/prod-347/ui-bundle.zip $ unzip ui-bundle.zip $ cd img $ du -kh . 452K $ open -a ImageOptim *.svg *.png $ du -kh . 416K min2.png (view on web) <https://github.com/user-attachments/assets/d1fd929d-7653-48cd-abcf-c9b782c0d9d4> — Reply to this email directly, view it on GitHub <#134 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAATL54VP4H4BOHZ2PCWDOTZZETO7AVCNFSM6AAAAABPC2V2M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBSHAYTQMJUGM> . You are receiving this because you commented.Message ID: ***@***.***>

[mojavelinux]

asciidoctor-og.png could/should be converted to an SVG as well.

From my understanding, social networks still don't properly support SVG. So the PNG is necessary. If you have a reference that cites the contrary, please share and I will study it.