GH-419: Remove deprecated RamFileSystemProvider for v1.0.0

- Remove deprecated RamFileSystemProvider
- Fix JimfsFileSystemProviderImpl to make use of the provided file system name
- Fix a couple of bugs regarding JimfsFileSystemProvider disallowing specific
  characters in file system names.

Author: ascopes

java-compiler-testing/src/main/java/io/github/ascopes/jct/utils/FileUtils.java

@@ -122,7 +122,7 @@ public static void assertValidRootName(@Nullable String name) {
       );
     }
 
-    if (name.contains("/") || name.contains("\\") || name.contains("..")) {
+    if (name.contains("/") || name.contains("\\") || name.contains("..") || name.contains("_")) {
       throw new IllegalArgumentException(
           "Invalid file name provided: " + StringUtils.quoted(name)
       );

java-compiler-testing/src/main/java/io/github/ascopes/jct/workspaces/RamFileSystemProvider.java

@@ -35,8 +35,7 @@
  * @since 0.7.0
  */
 @API(since = "0.7.0", status = Status.INTERNAL)
-@SuppressWarnings("removal")
-public final class MemoryFileSystemProvider implements RamFileSystemProvider {
+public final class MemoryFileSystemProvider {
 
   // We could initialise this lazily, but this class has fewer fields and initialisation
   // overhead than a lazy-loaded object would, so it doesn't really make sense to do it
@@ -57,7 +56,6 @@ private MemoryFileSystemProvider() {
     // Singleton object.
   }
 
-  @Override
   public FileSystem createFileSystem(String name) {
     try {
       return MemoryFileSystemBuilder.newLinux()

java-compiler-testing/src/main/java/io/github/ascopes/jct/workspaces/impl/MemoryFileSystemProvider.java

@@ -85,7 +85,6 @@ public void close() throws IOException {
    * @return the in-memory path.
    */
   public static RamDirectoryImpl newRamDirectory(String name) {
-
     assertValidRootName(name);
 
     // MemoryFileSystem needs unique FS names to work correctly, so use a UUID to enforce this.

java-compiler-testing/src/main/java/io/github/ascopes/jct/workspaces/impl/RamDirectoryImpl.java

@@ -136,7 +136,12 @@ public ManagedDirectory createPackage(Location location) {
       throw new IllegalArgumentException("Location must not be module-oriented");
     }
 
-    var dir = pathStrategy.newInstance(location.getName());
+    // Needs to be unique, and JIMFS cannot hold a file system name containing stuff like
+    // underscores.
+    var fsName = location.getName().replaceAll("[^A-Za-z0-9]", "")
+        + UUID.randomUUID();
+
+    var dir = pathStrategy.newInstance(fsName);
     paths.computeIfAbsent(location, unused -> new ArrayList<>()).add(dir);
     return dir;
   }

java-compiler-testing/src/main/java/io/github/ascopes/jct/workspaces/impl/WorkspaceImpl.java

@@ -98,7 +98,6 @@
  *    }
  * </code></pre>
  */
-@SuppressWarnings("removal")
 module io.github.ascopes.jct {
 
   ////////////////////

java-compiler-testing/src/main/java/module-info.java

@@ -160,6 +160,7 @@ void assertValidRootNameSucceedsForValidRootNames(String rootName) {
       "foo/bar, Invalid file name provided",
       "foo\\bar, Invalid file name provided",
       "foo\\../bar, Invalid file name provided",
+      "foo_bar, Invalid file name provided",
   })
   @ParameterizedTest(name = "\"{0}\" is not a valid root name and raises \"{1}\"")
   void assertValidRootNameFailsForInvalidRootNames(String rootName, String expectedError) {