Do not use Nexus plugin as it does not behave correctly

Author: ascopes

.github/workflows/deploy.yml

@@ -8,11 +8,6 @@ on:
         default: true
         type: boolean
 
-      skip-initial-verification:
-        description: "Skip tests, dependency check, formatting, licenses"
-        default: false
-        type: boolean
-
       version:
         description: "Version (leave blank to release non-SNAPSHOT patch)"
         default: ""
@@ -46,21 +41,6 @@ jobs:
           gpg-passphrase: GPG_PASSPHRASE
           gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
 
-      - name: Ensure all tests pass
-        if: ${{ ! inputs.skip-initial-verification }}
-        shell: bash
-        run: >-
-          ./mvnw 
-          -B 
-          -e
-          -T4
-          -U
-          -P dependency-check
-          --no-transfer-progress
-          -Dstyle.color=always
-          -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
-          clean verify
-
       - name: Configure Git
         shell: bash
         run: |-
@@ -95,7 +75,6 @@ jobs:
             "-Dlicense.skip=true"
             "-Dcheckstyle.skip=true"
             "-Preleases"
-            '-P!acceptance-tests'
           )
           
           run <<-SCRIPT          
@@ -115,6 +94,7 @@ jobs:
           SCRIPT
           
           success "Release has been performed successfully"
+          info "Please log onto the Nexus staging site and mark the release as closed to publish it"
 
         env:
           OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }}

acceptance-tests/pom.xml

@@ -59,7 +59,6 @@
     <maven.javadoc.skip>true</maven.javadoc.skip>
     <maven.release.skip>true</maven.release.skip>
     <skip-dependency-scan>true</skip-dependency-scan>
-    <skipNexusStagingDeployMojo>true</skipNexusStagingDeployMojo>
   </properties>
 
   <dependencyManagement>

pom.xml

@@ -33,6 +33,7 @@
 
   <modules>
     <module>java-compiler-testing</module>
+    <module>acceptance-tests</module>
   </modules>
 
   <inceptionYear>2022</inceptionYear>
@@ -605,24 +606,6 @@
             </execution>
           </executions>
         </plugin>
-
-        <plugin>
-          <!-- Swaps out the maven deploy steps with Nexus-specific logic that can automate staging
-               checks for us. -->
-          <groupId>org.sonatype.plugins</groupId>
-          <artifactId>nexus-staging-maven-plugin</artifactId>
-          <version>${nexus-staging-maven-plugin.version}</version>
-          <extensions>true</extensions>
-          <configuration>
-            <autoReleaseAfterClose>true</autoReleaseAfterClose>
-            <autoDropAfterRelease>true</autoDropAfterRelease>
-            <keepStagingRepositoryOnCloseRuleFailure>true</keepStagingRepositoryOnCloseRuleFailure>
-            <keepStagingRepositoryOnFailure>true</keepStagingRepositoryOnFailure>
-            <nexusUrl>https://s01.oss.sonatype.org/</nexusUrl>
-            <serverId>ossrh</serverId>
-            <updateReleaseInfo>true</updateReleaseInfo>
-          </configuration>
-        </plugin>
       </plugins>
     </pluginManagement>
 
@@ -722,21 +705,6 @@
       </build>
     </profile>
 
-    <profile>
-      <id>acceptance-tests</id>
-      <activation>
-        <activeByDefault>true</activeByDefault>
-      </activation>
-
-      <modules>
-        <!-- 
-          Activate these here so that they do not appear when Nexus is being
-          invoked
-        -->
-        <module>acceptance-tests</module>
-      </modules>
-    </profile>
-
     <profile>
       <id>releases</id>
 
@@ -788,12 +756,6 @@
               </execution>
             </executions>
           </plugin>
-
-          <!-- Swap out the deploy plugin with the Nexus support to skip staging entirely. -->
-          <plugin>
-            <groupId>org.sonatype.plugins</groupId>
-            <artifactId>nexus-staging-maven-plugin</artifactId>
-          </plugin>
         </plugins>
       </build>
     </profile>