Further tidyups

Author: ascopes

java-compiler-testing/src/main/java/io/github/ascopes/jct/assertions/AbstractContainerGroupAssert.java

@@ -25,7 +25,6 @@
 import org.apiguardian.api.API.Status;
 import org.assertj.core.api.AbstractAssert;
 import org.assertj.core.api.AbstractListAssert;
-import org.assertj.core.api.Assertions;
 import org.assertj.core.api.ObjectAssert;
 import org.jspecify.annotations.Nullable;
 

java-compiler-testing/src/main/java/io/github/ascopes/jct/assertions/JctCompilationAssert.java

@@ -51,6 +51,7 @@ public final class JctCompilationAssert extends
    *
    * @param value the value to assert on.
    */
+  @SuppressWarnings("DataFlowIssue")
   public JctCompilationAssert(@Nullable JctCompilation value) {
     super(value, JctCompilationAssert.class);
   }

java-compiler-testing/src/main/java/io/github/ascopes/jct/containers/impl/JarContainerImpl.java

@@ -217,7 +217,7 @@ public String inferBinaryName(PathFileObject javaFileObject) {
   }
 
   @Override
-  public Collection<Path> listAllFiles() throws IOException {
+  public Collection<Path> listAllFiles() {
     return holder.access().getAllFiles();
   }
 

java-compiler-testing/src/main/java/io/github/ascopes/jct/containers/impl/PathWrappingContainerImpl.java

@@ -67,7 +67,7 @@ public PathWrappingContainerImpl(Location location, PathRoot root) {
   }
 
   @Override
-  public void close() throws IOException {
+  public void close() {
     // Do nothing for this implementation. We have nothing to close here. Anything wrapped in
     // this type will be managed by the Workspace object instead if it needs to be closed.
   }

java-compiler-testing/src/main/java/io/github/ascopes/jct/filemanagers/JctFileManagers.java

@@ -17,7 +17,6 @@
 
 import io.github.ascopes.jct.compilers.JctCompiler;
 import io.github.ascopes.jct.filemanagers.impl.JctFileManagerFactoryImpl;
-import io.github.ascopes.jct.filemanagers.impl.JctFileManagerImpl;
 import io.github.ascopes.jct.utils.UtilityClass;
 import org.apiguardian.api.API;
 import org.apiguardian.api.API.Status;

java-compiler-testing/src/main/java/io/github/ascopes/jct/filemanagers/config/JctFileManagerJvmClassPathModuleConfigurer.java

@@ -20,9 +20,6 @@
 import io.github.ascopes.jct.utils.ModuleDiscoverer;
 import io.github.ascopes.jct.utils.SpecialLocationUtils;
 import io.github.ascopes.jct.utils.StringUtils;
-import io.github.ascopes.jct.workspaces.impl.WrappingDirectoryImpl;
-import java.nio.file.Path;
-import java.util.Map.Entry;
 import java.util.Set;
 import javax.tools.StandardLocation;
 import org.apiguardian.api.API;

java-compiler-testing/src/main/java/io/github/ascopes/jct/utils/IterableUtils.java

@@ -123,6 +123,7 @@ public static <T> List<T> combineOneOrMore(T first, T... rest) {
    * @param <T>       the input collection type.
    * @return the input array.
    */
+  @SuppressWarnings("RedundantSuppression")
   public static <T> T[] requireNonNullValues(
       @Nullable T @Nullable[] array,
       String arrayName
@@ -149,8 +150,9 @@ public static <T> T[] requireNonNullValues(
       throw new NullPointerException(error);
     }
 
-    // Cast is not redundant as we're casting away any nullability annotations for nullness
-    // typecheckers.
+    //noinspection RedundantCast -- Cast is not redundant as we're casting away any nullability
+    // annotations for nullness typecheckers. Don't let IntelliJ tell you otherwise as it is a
+    // bug.
     return (T[]) array;
   }
 }