Use tempfs for ErrorProne to work around bug in ErrorProne file handling

Author: ascopes

acceptance-tests/acceptance-tests-error-prone/src/test/groovy/io/github/ascopes/jct/acceptancetests/errorprone/ErrorProneTest.groovy

@@ -17,77 +17,83 @@ package io.github.ascopes.jct.acceptancetests.errorprone
 
 import io.github.ascopes.jct.compilers.JctCompiler
 import io.github.ascopes.jct.junit.JavacCompilerTest
-import io.github.ascopes.jct.workspaces.Workspaces
+import io.github.ascopes.jct.junit.JctExtension
+import io.github.ascopes.jct.junit.Managed
+import io.github.ascopes.jct.workspaces.PathStrategy
+import io.github.ascopes.jct.workspaces.Workspace
 import org.junit.jupiter.api.BeforeAll
 import org.junit.jupiter.api.DisplayName
+import org.junit.jupiter.api.extension.ExtendWith
 
 import static io.github.ascopes.jct.assertions.JctAssertions.assertThatCompilation
 import static org.assertj.core.api.Assumptions.assumeThat
 
 @DisplayName("Error-prone acceptance tests")
+@ExtendWith(JctExtension.class)
 class ErrorProneTest {
 
+  // Use tempdirectories as ErrorProne isn't compatible with the URLs memoryfilesystem emits. This
+  // is due to the path being left null in the implementation.
+  @Managed(pathStrategy = PathStrategy.TEMP_DIRECTORIES)
+  Workspace workspace;
+
   @BeforeAll
   static void workAroundIdea317391() {
     // Workaround for https://youtrack.jetbrains.com/issue/IDEA-317391
     assumeThat(System.getProperty("mvnArgLinePropagated", "false"))
-            .withFailMessage("Your IDE has not propagated the <argLine/> in the pom.xml")
-            .isEqualTo("true");
+        .withFailMessage("Your IDE has not propagated the <argLine/> in the pom.xml")
+        .isEqualTo("true");
   }
 
   @DisplayName("Happy paths work as expected")
   @JavacCompilerTest
   void happyPathsWorkAsExpected(JctCompiler compiler) {
-    try (def workspace = Workspaces.newWorkspace()) {
-      // Given
-      workspace
-          .createSourcePathPackage()
-          .createDirectory("org", "example")
-          .copyContentsFrom("src", "test", "resources", "code", "nullness", "happy")
+    // Given
+    workspace
+        .createSourcePathPackage()
+        .createDirectory("org", "example")
+        .copyContentsFrom("src", "test", "resources", "code", "nullness", "happy")
 
-      // When
-      def compilation = compiler
-          .addCompilerOptions(
-              "-Xplugin:ErrorProne",
-              "-XDcompilePolicy=simple",
-          )
-          .compile(workspace)
+    // When
+    def compilation = compiler
+        .addCompilerOptions(
+            "-Xplugin:ErrorProne",
+            "-XDcompilePolicy=simple",
+        )
+        .compile(workspace)
 
-      // Then
-      assertThatCompilation(compilation)
-          .isSuccessfulWithoutWarnings()
-    }
+    // Then
+    assertThatCompilation(compilation)
+        .isSuccessfulWithoutWarnings()
   }
 
   @DisplayName("Sad paths fail as expected")
   @JavacCompilerTest
   void sadPathsFailAsExpected(JctCompiler compiler) {
-    try (def workspace = Workspaces.newWorkspace()) {
-      // Given
-      workspace
-          .createSourcePathPackage()
-          .createDirectory("org", "example")
-          .copyContentsFrom("src", "test", "resources", "code", "nullness", "sad")
+    // Given
+    workspace
+        .createSourcePathPackage()
+        .createDirectory("org", "example")
+        .copyContentsFrom("src", "test", "resources", "code", "nullness", "sad")
 
-      // When
-      def compilation = compiler
-          .addCompilerOptions(
-              "-Xplugin:ErrorProne",
-              "-XDcompilePolicy=simple",
-          )
-          .compile(workspace)
+    // When
+    def compilation = compiler
+        .addCompilerOptions(
+            "-Xplugin:ErrorProne",
+            "-XDcompilePolicy=simple",
+        )
+        .compile(workspace)
 
-      // Then
-      assertThatCompilation(compilation)
-          .isFailure()
-          .diagnostics()
-          .errors()
-          .singleElement()
-          .message()
-          .startsWith(
-              "[MustBeClosedChecker] This method returns a resource which must be managed "
-                  + "carefully, not just left for garbage collection."
-          )
-    }
+    // Then
+    assertThatCompilation(compilation)
+        .isFailure()
+        .diagnostics()
+        .errors()
+        .singleElement()
+        .message()
+        .startsWith(
+            "[MustBeClosedChecker] This method returns a resource which must be managed "
+                + "carefully, not just left for garbage collection."
+        )
   }
 }