misaligned pointer dereference: address must be a multiple of 0x8 but is 0x100384d7c', src/window.rs:92:15

Author: Buggaboo

examples/sum_int.rs

@@ -3,7 +3,7 @@
 
 use libsqlite3_sys::sqlite3_int64;
 use sqlite_loadable::prelude::*;
-use sqlite_loadable::window::{WindowFunctionCallbacks, define_window_function};
+use sqlite_loadable::window::define_window_function;
 use sqlite_loadable::{api, Result};
 
 /// Example inspired by sqlite3's sumint
@@ -16,7 +16,6 @@ pub fn x_step(context: *mut sqlite3_context, values: &[*mut sqlite3_value]) -> R
     Ok(())
 }
 
-
 pub fn x_final(context: *mut sqlite3_context) -> Result<()> {
     let value = api::get_aggregate_context_value::<sqlite3_int64>(context)?;
     api::result_int64(context, value);
@@ -41,8 +40,9 @@ pub fn x_inverse(context: *mut sqlite3_context, values: &[*mut sqlite3_value]) -
 #[sqlite_entrypoint]
 pub fn sqlite3_sumint_init(db: *mut sqlite3) -> Result<()> {
     let flags = FunctionFlags::UTF8 | FunctionFlags::DETERMINISTIC;
-    define_window_function(db, "sumint", -1, flags,
-    WindowFunctionCallbacks::new(x_step, x_final, x_value, x_inverse))?;
+    define_window_function(
+        db, "sumint", -1, flags,
+        x_step, x_final, Some(x_value), Some(x_inverse))?;
     Ok(())
 }
 

src/ext.rs

@@ -322,19 +322,19 @@ pub unsafe fn sqlite3ext_create_window_function(
     argc: i32,
     text_rep: i32,
     p_app: *mut c_void,
-    x_step: Option<unsafe extern "C" fn(*mut sqlite3_context, i32, *mut *mut sqlite3_value)>,
-    x_final: Option<unsafe extern "C" fn(*mut sqlite3_context)>,
+    x_step: unsafe extern "C" fn(*mut sqlite3_context, i32, *mut *mut sqlite3_value),
+    x_final: unsafe extern "C" fn(*mut sqlite3_context),
     x_value: Option<unsafe extern "C" fn(*mut sqlite3_context)>,
     x_inverse: Option<unsafe extern "C" fn(*mut sqlite3_context, i32, *mut *mut sqlite3_value)>,
     destroy: Option<unsafe extern "C" fn(*mut c_void)>
 ) -> c_int {
     if SQLITE3_API.is_null() {
         sqlite3_create_window_function(
-            db, s, argc, text_rep, p_app, x_step, x_final, x_value, x_inverse, destroy,
+            db, s, argc, text_rep, p_app, Some(x_step), Some(x_final), x_value, x_inverse, destroy,
         )
     } else {
         ((*SQLITE3_API).create_window_function.expect(EXPECT_MESSAGE))(
-            db, s, argc, text_rep, p_app, x_step, x_final, x_value, x_inverse, destroy,
+            db, s, argc, text_rep, p_app, Some(x_step), Some(x_final), x_value, x_inverse, destroy,
         )
     }
 }

src/lib.rs

@@ -27,7 +27,7 @@ pub use bit_flags::FunctionFlags;
 pub use scalar::{define_scalar_function, define_scalar_function_with_aux};
 
 #[doc(inline)]
-pub use window::{WindowFunctionCallbacksWithAux, define_window_function_with_aux};
+pub use window::define_window_function;
 
 #[doc(inline)]
 pub use collation::define_collation;

src/scalar.rs

@@ -139,7 +139,7 @@ where
         let aux = (*x).1;
         // .collect slows things waaaay down, so stick with slice for now
         let args = slice::from_raw_parts(argv, argc as usize);
-        let b = Box::from_raw(aux);
+        let b: Box<T> = Box::from_raw(aux);
         match (*boxed_function)(context, args, &*b) {
             Ok(()) => (),
             Err(e) => {