Merge pull request #217 from brionmario/thunder

fix: `SignInButton` issue with `AsgardeoV2`

Author: brionmario

.changeset/lazy-forks-sneeze.md

@@ -0,0 +1,6 @@
+---
+'@asgardeo/react': patch
+'@asgardeo/javascript': patch
+---
+
+Fix `SignInButton` issue with `AsgardeoV2`

README.md

@@ -48,6 +48,14 @@ Follow these simple steps to get started with Asgardeo:
 
 Please read [Contributing Guide](CONTRIBUTING.md) for details on how to contribute to Asgardeo JavaScript SDKs. Refer to [General Contribution Guidelines](http://wso2.github.io/) for details on our code of conduct, and the process for submitting pull requests to us.
 
+### Contributors ❤️
+
+Hats off to all the people who have contributed to this project, including those who created issues and participated in discussions. 🙌
+
+<a href="https://github.com/asgardeo/javascript/graphs/contributors">
+  <img src="https://contrib.rocks/image?repo=asgardeo/javascript" />
+</a>
+
 ### Reporting issues
 
 We encourage you to report issues, improvements, and feature requests creating [Github Issues](https://github.com/asgardeo/javascript/issues).

packages/javascript/src/models/embedded-flow.ts

@@ -16,8 +16,6 @@
  * under the License.
  */
 
-import {Platform} from './platforms';
-
 export enum EmbeddedFlowType {
   Authentication = 'AUTHENTICATION',
   Registration = 'REGISTRATION',

packages/react/src/AsgardeoReactClient.ts

@@ -48,6 +48,7 @@ import {
   Config,
   TokenExchangeRequestConfig,
   Platform,
+  isEmpty,
 } from '@asgardeo/browser';
 import AuthAPI from './__temp__/api';
 import getMeOrganizations from './api/getMeOrganizations';
@@ -334,7 +335,7 @@ class AsgardeoReactClient<T extends AsgardeoReactConfig = AsgardeoReactConfig> e
 
       const config: AsgardeoReactConfig = (await this.asgardeo.getConfigData()) as AsgardeoReactConfig;
 
-      if (config.platform === Platform.AsgardeoV2) {
+      if (config.platform === Platform.AsgardeoV2 && typeof arg1 === 'object' && !isEmpty(arg1)) {
         const sessionDataKey: string = new URL(window.location.href).searchParams.get('sessionDataKey');
 
         return executeEmbeddedSignInFlowV2({

packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx

@@ -346,7 +346,7 @@ const AsgardeoProvider: FC<PropsWithChildren<AsgardeoProviderProps>> = ({
   useEffect(() => {
     // TEMPORARY: Asgardeo V2 platform does not support branding preference yet.
     // Tracker: https://github.com/asgardeo/javascript/issues/212
-    if (config.platform !== Platform.AsgardeoV2) {
+    if (config.platform === Platform.AsgardeoV2) {
       return;
     }