Skip to content

Commit 8e318fa

Browse files
committed
docs: update contributing guide to reflect Asgardeo JavaScript SDKs
1 parent 51d2bd0 commit 8e318fa

File tree

1 file changed

+59
-149
lines changed

1 file changed

+59
-149
lines changed

CONTRIBUTING.md

Lines changed: 59 additions & 149 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
# Contributing to Asgardeo Web UI SDKs
1+
# Contributing to Asgardeo JavaScript SDKs
22

3-
This guide walks you through setting up the development environment and other important information for contributing to Asgardeo Web UI SDKs.
3+
This guide walks you through setting up the development environment and other important information for contributing to Asgardeo JavaScript SDKs.
44

55
## Table of Contents
6+
67
- [Prerequisite Software](#prerequisite-software)
78
- [Development Tools](#development-tools)
89
- [NX Console](#nx-console)
@@ -26,44 +27,18 @@ This guide walks you through setting up the development environment and other im
2627

2728
To build and write code, make sure you have the following set of tools on your local environment:
2829

29-
* [Git](https://git-scm.com/downloads) - Open source distributed version control system. For install instructions, refer [this](https://www.atlassian.com/git/tutorials/install-git).
30-
* [Node.js](https://nodejs.org/en/download/) - JavaScript runtime. (`v18 or higher`)
31-
* [pnpm](https://pnpm.io/) - Alternate npm client for faster package installs. (`v9 or higher`)
30+
- [Git](https://git-scm.com/downloads) - Open source distributed version control system. For install instructions, refer [this](https://www.atlassian.com/git/tutorials/install-git).
31+
- [Node.js](https://nodejs.org/en/download/) - JavaScript runtime. (`v18 or higher`)
32+
- [pnpm](https://pnpm.io/) - Alternate npm client for faster package installs. (`v9 or higher`)
3233

3334
## Development Tools
3435

35-
### NX Console
36-
37-
Editor plugin which wraps NX commands so you don't have to memorize.
38-
39-
- [Install for VS Code](https://marketplace.visualstudio.com/items?itemName=nrwl.angular-console)
40-
- [Install for VS Web Storm](https://plugins.jetbrains.com/plugin/15000-nx-webstorm)
41-
42-
### React Developer Tools
43-
44-
Browser extension to debug React code.
45-
46-
- [Download for Chrome](https://chrome.google.com/webstore/detail/react-developer-tools/fmkadmapgofadopljbjfkapdkoienihi?hl=en)
47-
- [Download for Firefox](https://addons.mozilla.org/en-US/firefox/addon/react-devtools/)
48-
49-
### ESLint Plugin
50-
51-
Static code analysis tool for identifying problematic patterns found in JavaScript/Typescript code.
52-
53-
- [Install for VS Code](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint)
54-
- [Install for VS Web Storm](https://www.jetbrains.com/help/webstorm/eslint.html)
55-
56-
### Code Spell Checker
57-
58-
A basic spell checker that works well with code and documents.
59-
60-
- [Install for VS Code](https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker)
61-
62-
### JSON Sort Order
63-
64-
Sorts JSON objects in alphabetical order.
65-
66-
- [Install for VS Code](https://marketplace.visualstudio.com/items?itemName=msyesyan.json-sorter)
36+
| Extension | Description | VS Code Marketplace |
37+
|-----------|-------------|---------------------|
38+
| NX Console | Editor plugin which wraps NX commands so you don't have to memorize. | [Install](https://marketplace.visualstudio.com/items?itemName=nrwl.angular-console) |
39+
| ESLint | Static code analysis tool for identifying problematic patterns found in JavaScript/Typescript code. | [Install](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) |
40+
| Code Spell Checker | A basic spell checker that works well with code and documents. | [Install](https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker) |
41+
| JSON Sort Order | Sorts JSON objects in alphabetical order. | [Install](https://marketplace.visualstudio.com/items?itemName=msyesyan.json-sorter) |
6742

6843
## Setting up the Source Code
6944

@@ -98,151 +73,86 @@ pnpm build
9873

9974
## Contributing to the Documentation
10075

101-
We use [Vitepress](https://vitepress.dev/) to generate the documentation site. The documentation site is located in the `docs` directory.
102-
To contribute to the documentation, you can follow the steps below to start the Vitepress server locally.
76+
The documentation for Asgardeo JavaScript SDKs is maintained in the Asgardeo / WSO2 Identity Server Official Docs site.
10377

104-
1. Navigate to the `docs` directory.
78+
- [Asgardeo Docs](https://wso2.com/asgardeo/docs)
79+
- [WSO2 Identity Server Docs](https://is.docs.wso2.com/en/latest/)
10580

106-
```bash
107-
cd docs
108-
```
109-
110-
2. Start the Vitepress server.
111-
112-
```bash
113-
pnpm docs:dev
114-
```
81+
To contribute to the documentation, please send a pull request to the [Asgardeo Docs repository](https://github.com/wso2/docs-is).
11582

11683
## Commit Message Guidelines
11784

118-
*This specification is inspired by and supersedes the [AngularJS commit message format][commit-message-format].*
119-
120-
We have very precise rules over how our Git commit messages must be formatted.
121-
This format leads to **easier to read commit history**.
122-
123-
Each commit message consists of a **header**, a **body**, and a **footer**.
124-
125-
```
126-
<header>
127-
<BLANK LINE>
128-
<body>
129-
<BLANK LINE>
130-
<footer>
131-
```
132-
133-
The `header` is mandatory and must conform to the [Commit Message Header](#commit-header) format.
134-
135-
The `body` is mandatory for all commits except for those of type "docs".
136-
When the body is present it must be at least 20 characters long and must conform to the [Commit Message Body](#commit-body) format.
85+
We use [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) as the commit message convention.
13786

138-
The `footer` is optional. The [Commit Message Footer](#commit-footer) format describes what the footer is used for and the structure it must have.
87+
Please refer to the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) documentation for more information.
13988

89+
> [!IMPORTANT]
90+
>
91+
> 1. Use the imperative, present tense: "change" not "changed" nor "changes".
92+
> 2. Don't capitalize the first letter.
93+
> 3. No dot (.) at the end.
14094
141-
### <a name="commit-header"></a>Commit Message Header
142-
143-
```
144-
<type>(<scope>): <short summary>
145-
│ │ │
146-
│ │ └─⫸ Summary in present tense. Not capitalized. No period at the end.
147-
│ │
148-
│ └─⫸ Commit Scope: primitives|scss|react|vue|nuxt
149-
150-
└─⫸ Commit Type: build|ci|docs|feat|fix|perf|refactor|chore|test
151-
```
152-
153-
The `<type>` and `<summary>` fields are mandatory, the `(<scope>)` field is optional.
154-
155-
156-
#### Type
95+
### Types
15796

15897
Must be one of the following:
15998

160-
* **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
161-
* **ci**: Changes to our CI configuration files and scripts (examples: CircleCi, SauceLabs)
162-
* **docs**: Documentation only changes
163-
* **feat**: A new feature
164-
* **fix**: A bug fix
165-
* **perf**: A code change that improves performance
166-
* **refactor**: A code change that neither fixes a bug nor adds a feature
167-
* **chore**: Housekeeping tasks that doesn't require to be highlighted in the changelog
168-
* **test**: Adding missing tests or correcting existing tests
99+
- **chore**: Housekeeping tasks that doesn't require to be highlighted in the changelog
100+
- **feat**: A new feature
101+
- **ci**: Changes to our CI configuration files and scripts (examples: GitHub Actions)
102+
- **fix**: A bug fix
103+
- **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
104+
- **docs**: Documentation only changes
105+
- **perf**: A code change that improves performance
106+
- **refactor**: A code change that neither fixes a bug nor adds a feature
107+
- **test**: Adding missing tests or correcting existing tests
169108

109+
### Scope
170110

171-
#### Scope
172111
The scope should be the name of the npm package affected (as perceived by the person reading the changelog generated from commit messages).
173112

174113
The following is the list of supported scopes:
175114

176-
* `core` - Changes to the `core` / `@asgardeo/js` package.
177-
* `react` - Changes to the `@asgardeo/react` package.
178-
* `vue` - Changes to the `@asgardeo/vue` package.
179-
* `nuxt` - Changes to the `@asgardeo/nuxt` package.
180-
* `workspace` - Changes to the workspace.
181-
* `sample-app` - Changes to the sample app.
182-
183-
There are currently a few exceptions to the "use package name" rule:
184-
185-
* `packaging`: used for changes that change the npm package layout in all of our packages, e.g. public path changes, package.json changes done to all packages, d.ts file/format changes, changes to bundles, etc.
186-
187-
* `changelog`: used for updating the release notes in CHANGELOG.md
188-
189-
* `dev-infra`: used for dev-infra related changes within the directories like /scripts.
190-
191-
* `docs-infra`: used for docs page changes. (`<ROOT>/docs`)
192-
193-
* none/empty string: useful for `test` and `refactor` changes that are done across all packages (e.g. `test: add missing unit tests`) and for docs changes that are not related to a specific package (e.g. `docs: fix typo in example`).
194-
195-
196-
#### Summary
197-
198-
Use the summary field to provide a succinct description of the change:
115+
- `javascript` - Changes to the `@asgardeo/javascript` package.
116+
- `browser` - Changes to the `@asgardeo/browser` package.
117+
- `node` - Changes to the `@asgardeo/node` package.
118+
- `express` - Changes to the `@asgardeo/express` package.
119+
- `i18n` - Changes to the `@asgardeo/i18n` package.
120+
- `react` - Changes to the `@asgardeo/react` package.
121+
- `react-router` - Changes to the `@asgardeo/react-router` package.
122+
- `nextjs` - Changes to the `@asgardeo/nextjs` package.
123+
- `vue` - Changes to the `@asgardeo/vue` package.
124+
- `nuxt` - Changes to the `@asgardeo/nuxt` package.
199125

200-
* Use the imperative, present tense: "change" not "changed" nor "changes".
201-
* Don't capitalize the first letter.
202-
* No dot (.) at the end.
126+
> [!NOTE]
127+
> If the change affects multiple packages, just use the type without a scope, e.g., `fix: ...`.
203128
129+
### Example Commit Message
204130

205-
### <a name="commit-body"></a>Commit Message Body
206-
207-
Just as in the summary, use the imperative, present tense: "fix" not "fixed" nor "fixes".
208-
209-
Explain the motivation for the change in the commit message body. This commit message should explain _why_ you are making the change.
210-
You can include a comparison of the previous behavior with the new behavior in order to illustrate the impact of the change.
211-
212-
213-
### <a name="commit-footer"></a>Commit Message Footer
214-
215-
The footer can contain information about breaking changes and deprecations and is also the place to reference GitHub issues, Jira tickets, and other PRs that this commit closes or is related to.
216-
For example:
131+
Each commit message consists of a **header**, a **body**, and a **footer**.
217132

218133
```
219-
BREAKING CHANGE: <breaking change summary>
220-
<BLANK LINE>
221-
<breaking change description + migration instructions>
134+
<type>(<scope>): <short summary>
222135
<BLANK LINE>
136+
<body>
223137
<BLANK LINE>
224-
Fixes #<issue number>
138+
<footer>
225139
```
226140

227-
or
228-
229-
```
230-
DEPRECATED: <what is deprecated>
231-
<BLANK LINE>
232-
<deprecation description + recommended update path>
233-
<BLANK LINE>
234-
<BLANK LINE>
235-
Closes #<pr number>
236141
```
142+
# Update issue templates to include '@asgardeo/i18n' and improve version description
143+
chore: update issue templates to include '@asgardeo/i18n' and improve version description
237144
238-
Breaking Change section should start with the phrase "BREAKING CHANGE: " followed by a summary of the breaking change, a blank line, and a detailed description of the breaking change that also includes migration instructions.
145+
# Add a new feature to the react package.
146+
feat(react): add `SignInWithPopup` method to facilitate popup-based authentication flows.
239147
240-
Similarly, a Deprecation section should start with "DEPRECATED: " followed by a short description of what is deprecated, a blank line, and a detailed description of the deprecation that also mentions the recommended update path.
148+
# Update GitHub Actions workflows to include linting and testing steps.
149+
ci: enhance GitHub Actions workflows with linting and testing steps
241150
151+
```
242152

243153
### Revert commits
244154

245-
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit.
155+
If the commit reverts a previous commit, it should begin with `revert:`, followed by the header of the reverted commit.
246156

247157
The content of the commit message body should contain:
248158

0 commit comments

Comments
 (0)