Skip to content

Commit 5a8b29c

Browse files
authored
Merge pull request #2234 from brionmario/bug-fix-2158
Fix image `alt` not resolving `i18n` values in Thunder Gate
2 parents 18b7582 + 7f06708 commit 5a8b29c

File tree

1 file changed

+3
-2
lines changed
  • frontend/packages/thunder-shared-design/src/components/flow/adapters

1 file changed

+3
-2
lines changed

frontend/packages/thunder-shared-design/src/components/flow/adapters/ImageAdapter.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export default function ImageAdapter({
3838
maxHeight = '100%',
3939
}: ImageAdapterProps): JSX.Element | null {
4040
const resolvedSrc = resolve(component.src ?? '') ?? component.src ?? '';
41+
const resolvedAlt = resolve(component.alt ?? '') ?? component.alt ?? '';
4142

4243
if (!resolvedSrc) return null;
4344

@@ -66,7 +67,7 @@ export default function ImageAdapter({
6667
width: cssWidth,
6768
}}
6869
>
69-
<span aria-label={component.alt ?? ''} role="img" style={{fontSize: '100cqmin', lineHeight: 1}}>
70+
<span aria-label={resolvedAlt} role="img" style={{fontSize: '100cqmin', lineHeight: 1}}>
7071
{extractEmojiFromUri(resolvedSrc)}
7172
</span>
7273
</span>
@@ -78,7 +79,7 @@ export default function ImageAdapter({
7879
component="img"
7980
className={cn('Flow--image')}
8081
src={resolvedSrc}
81-
alt={component.alt ?? ''}
82+
alt={resolvedAlt}
8283
sx={{
8384
width: component.width ? `${component.width}px` : 'auto',
8485
height: component.height ? `${component.height}px` : 'auto',

0 commit comments

Comments
 (0)