fix: pass full context to Ash.load! in cascade changes (#2537)

* fix: pass full context to `Ash.load!` in cascade changes

The `Ash.load!` calls in `cascade_destroy` and `cascade_update` were
only passing `tenant: tenant`, missing the actor and other context
options. This caused policy failures when policies require an actor.

Use `Ash.Context.to_opts(context)` to pass all relevant context options
(actor, tenant, tracer, context, authorize?), consistent with how
`context_opts` is already passed to `Ash.bulk_destroy!`/`Ash.bulk_update!`
in the same code path.

Closes #2536

* fix: use scope option instead of to_opts for Ash.load! in cascade changes

* fix: avoid shadowing context variable in cascade changes

Rename the rebound `context` variable to `action_context` to preserve
the original context parameter containing tenant, actor, and tracer.
This ensures `scope: context` in `Ash.load!` receives the full context.

* fix: remove `authorize?: false` from cascade `Ash.load!` calls

Authorization was intentionally removed in #1948 in favour of
`accessing_from` policies. Passing `authorize?: false` here would
bypass that intent.

Author: jimsynz

lib/ash/resource/change/cascade_destroy.ex

@@ -283,7 +283,7 @@ defmodule Ash.Resource.Change.CascadeDestroy do
 
   defp destroy_related([], _, _, _), do: :ok
 
-  defp destroy_related(data, opts, %{tenant: tenant} = context, changeset) do
+  defp destroy_related(data, opts, context, changeset) do
     action = opts.action
     relationship = opts.relationship
 
@@ -296,7 +296,7 @@ defmodule Ash.Resource.Change.CascadeDestroy do
         return_notifications?: opts.return_notifications?
       )
 
-    context =
+    action_context =
       Map.merge(relationship.context || %{}, %{
         cascade_destroy: true,
         accessing_from: %{source: relationship.source, name: relationship.name}
@@ -306,8 +306,8 @@ defmodule Ash.Resource.Change.CascadeDestroy do
       Keyword.update(
         context_opts,
         :context,
-        context,
-        &Map.merge(&1, context)
+        action_context,
+        &Map.merge(&1, action_context)
       )
 
     case related_query(data, opts, context_opts) do
@@ -346,7 +346,7 @@ defmodule Ash.Resource.Change.CascadeDestroy do
           |> List.wrap()
           |> Ash.load!(
             [{relationship.name, load_query}],
-            tenant: tenant
+            scope: context
           )
           |> Enum.flat_map(fn record ->
             record
@@ -359,8 +359,8 @@ defmodule Ash.Resource.Change.CascadeDestroy do
             Keyword.update(
               context_opts,
               :context,
-              context,
-              &Map.merge(&1, context)
+              action_context,
+              &Map.merge(&1, action_context)
             )
           )
         end

lib/ash/resource/change/cascade_update.ex

@@ -188,7 +188,7 @@ defmodule Ash.Resource.Change.CascadeUpdate do
 
   defp update_related(_, [], _, _), do: :ok
 
-  defp update_related(changeset, data, opts, %{tenant: tenant} = context) do
+  defp update_related(changeset, data, opts, context) do
     action = opts.action
     relationship = opts.relationship
     copies = opts.copy_inputs
@@ -214,7 +214,7 @@ defmodule Ash.Resource.Change.CascadeUpdate do
         return_notifications?: opts.return_notifications?
       )
 
-    context =
+    action_context =
       Map.merge(relationship.context || %{}, %{
         cascade_update: true,
         accessing_from: %{source: relationship.source, name: relationship.name}
@@ -224,8 +224,8 @@ defmodule Ash.Resource.Change.CascadeUpdate do
       Keyword.update(
         context_opts,
         :context,
-        context,
-        &Map.merge(&1, context)
+        action_context,
+        &Map.merge(&1, action_context)
       )
 
     case related_query(data, opts, context_opts) do
@@ -260,7 +260,7 @@ defmodule Ash.Resource.Change.CascadeUpdate do
         |> List.wrap()
         |> Ash.load!(
           [{relationship.name, load_query}],
-          tenant: tenant
+          scope: context
         )
         |> Enum.flat_map(fn record ->
           record
@@ -273,8 +273,8 @@ defmodule Ash.Resource.Change.CascadeUpdate do
           Keyword.update(
             context_opts,
             :context,
-            context,
-            &Map.merge(&1, context)
+            action_context,
+            &Map.merge(&1, action_context)
           )
         )
     end