Skip to content

Commit a6b1089

Browse files
authored
improvement: Change level of repetitive log (#324)
* Handle display of Postgrex range * Add way to prevent logging error of Failed to display value * Remove config option to silence log and instead just log as debug * Improve matching of Postgrex.Range struct
1 parent 4d11594 commit a6b1089

File tree

1 file changed

+29
-2
lines changed
  • lib/ash_admin/components/resource

1 file changed

+29
-2
lines changed

lib/ash_admin/components/resource/show.ex

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ defmodule AshAdmin.Components.Resource.Show do
126126
}>
127127
{inspect(@calculation_errors[calculation.name])}
128128
</.error>
129-
<div class="px-4 py-3 text-right sm:px-6 text-right">
129+
<div class="px-4 py-3 text-right sm:px-6">
130130
<button
131131
type="submit"
132132
class="py-2 px-4 mt-2 bg-indigo-600 text-white border-gray-600 hover:bg-gray-400 rounded-md justify-center items-center"
@@ -912,6 +912,33 @@ defmodule AshAdmin.Components.Resource.Show do
912912
end
913913
end
914914

915+
defp value!(%{
916+
__struct__: Postgrex.Range,
917+
lower: lower,
918+
upper: upper,
919+
lower_inclusive: lower_inclusive,
920+
upper_inclusive: upper_inclusive
921+
}) do
922+
lower_str =
923+
case lower do
924+
:unbound -> "-∞"
925+
%DateTime{} = dt -> DateTime.to_string(dt)
926+
other -> inspect(other)
927+
end
928+
929+
upper_str =
930+
case upper do
931+
:unbound -> "+∞"
932+
%DateTime{} = dt -> DateTime.to_string(dt)
933+
other -> inspect(other)
934+
end
935+
936+
lower_bracket = if lower_inclusive, do: "[", else: "("
937+
upper_bracket = if upper_inclusive, do: "]", else: ")"
938+
939+
"#{lower_bracket}#{lower_str}, #{upper_str}#{upper_bracket}"
940+
end
941+
915942
defp value!(value) do
916943
data = Phoenix.HTML.Safe.to_iodata(value)
917944

@@ -922,7 +949,7 @@ defmodule AshAdmin.Components.Resource.Show do
922949
end
923950
rescue
924951
e ->
925-
Logger.error("Failed to display value:\n#{Exception.format(:error, e, __STACKTRACE__)}")
952+
Logger.debug("Failed to display value:\n#{Exception.format(:error, e, __STACKTRACE__)}")
926953
"<display error>"
927954
end
928955

0 commit comments

Comments
 (0)