fix(DynamicType): ensure updateTraitCollection handles Dynamic Type reliably

sanitize test artifacts names avoiding trailing '_' before scale suffix
disable carthage from CI

Author: dogo

.github/workflows/build-and-test.yml

@@ -26,9 +26,11 @@ jobs:
       - name: Run tests in Swift 5.X
         run: xcodebuild -workspace 'Bootstrap/Bootstrap.xcworkspace' -sdk 'iphonesimulator' -scheme 'Bootstrap' -destination 'name=iPhone SE (3rd generation)' SWIFT_VERSION=5.0 build test | tee output/xcodebuild_swift5.0.log
 
-      - name: Run Carthage integration test
-        run: carthage bootstrap --use-xcframeworks --platform iOS,tvOS && xcodebuild
-        shell: bash
+      # Carthage integration test is disabled due to incompatibility issues with newer versions of Quick/Nimble
+      # https://github.com/ashfurrow/Nimble-Snapshots/issues/286
+      #- name: Run Carthage integration test
+      #  run: carthage bootstrap --use-xcframeworks --platform iOS,tvOS && xcodebuild
+      #  shell: bash
 
       - name: Swiftlint
         run: |

Bootstrap/BootstrapTests/DynamicTypeTests.swift

@@ -88,6 +88,7 @@ final class DynamicTypeTests: QuickSpec {
                 label.font = .preferredFont(forTextStyle: .body)
 
                 expect(label) == dynamicTypeSnapshot()
+                // expect(label) == recordDynamicTypeSnapshot()
             }
 
             it("works with adjustsFontForContentSizeCategory in a subview") {
@@ -100,6 +101,7 @@ final class DynamicTypeTests: QuickSpec {
                 view.addSubview(label)
 
                 expect(view) == dynamicTypeSnapshot()
+                // expect(view) == recordDynamicTypeSnapshot()
             }
 
             it("works with traitCollectionDidChange in a view controller from a storyboard") {
@@ -109,6 +111,7 @@ final class DynamicTypeTests: QuickSpec {
                 controller?.endAppearanceTransition()
 
                 expect(controller).to(haveValidDynamicTypeSnapshot())
+                // expect(controller) == recordDynamicTypeSnapshot()
             }
         }
     }