Nimble-Snapshots does not work properly if UIApperance attributes change intrinsic content size of view being tested

[jgongo]

I'm having a problem regarding a view that isn't being properly recorded when I change an attribute of the view using the UIAppearance proxy, if that attribute would change the intrinsic content size of the view. In this case, the image is clipped to the original size of the view.

This seems to be caused by a bug in ios-snapshot-test-case.

[jgongo]

I have noticed this also happens when setting a property that changes the intrinsic content size (for example, setting a large text)

[ashfurrow]

Interesting, can you expand? What does the failing test code look like?

[jgongo]

I've added a comment in the ios-snapshot-test-case bug with a test case and a bit of explanation

[jgongo]

And a pull request ;) It would be great if you could release a new version whenever they accept the PR, I'll keep you posted. Thanks!

[ashfurrow]

Okay, sounds good 👍 Just let me know what we can to do help.

[Vkt0r]

@ashfurrow I think with #147 and the update of the version of the library Uber fixed this issue in the latest version according to its CHANGELOG.

@jgongo Could you validate if the bug is happening using the latest version of the ios-snapshot-test-case library? In case of it was fixed we can close this issue 😃

[Vkt0r]

This can be closed as it was solved in #147. @jgongo Please reopen it in case it comes back (I hope not 🤞)