Set to null instead of false (#154)

izzygld · web-flow · commit 7a97fcfd5e32 · 2023-04-17T17:42:58.000+01:00
diff --git a/wp-graphql-yoast-seo.php b/wp-graphql-yoast-seo.php
@@ -130,6 +130,7 @@ function wpcom_vip_attachment_url_to_postid($url)
                         'default',
                         12 * HOUR_IN_SECONDS + mt_rand(0, 4 * HOUR_IN_SECONDS) // phpcs:ignore
                     );
+                    $id = null; // Set $id to null instead of false
                 } else {
                     wp_cache_set(
                         $cache_key,
@@ -139,12 +140,12 @@ function wpcom_vip_attachment_url_to_postid($url)
                     );
                 }
             } elseif ('not_found' === $id) {
-                return false;
+                return null; // Return null instead of false
             }
-
+    
             return $id;
         }
-    }
+    }    
 
     function wp_gql_seo_build_content_types($types)
     {

Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,7 @@ function wpcom_vip_attachment_url_to_postid($url)`
`130`	`130`	`'default',`
`131`	`131`	`12 * HOUR_IN_SECONDS + mt_rand(0, 4 * HOUR_IN_SECONDS) // phpcs:ignore`
`132`	`132`	`);`
	`133`	`+ $id = null; // Set $id to null instead of false`
`133`	`134`	`} else {`
`134`	`135`	`wp_cache_set(`
`135`	`136`	`$cache_key,`
`@@ -139,12 +140,12 @@ function wpcom_vip_attachment_url_to_postid($url)`
`139`	`140`	`);`
`140`	`141`	`}`
`141`	`142`	`} elseif ('not_found' === $id) {`
`142`		`- return false;`
	`143`	`+ return null; // Return null instead of false`
`143`	`144`	`}`
`144`		`-`
	`145`	`+`
`145`	`146`	`return $id;`
`146`	`147`	`}`
`147`		`- }`
	`148`	`+ }`
`148`	`149`
`149`	`150`	`function wp_gql_seo_build_content_types($types)`
`150`	`151`	`{`