Duplicate field notice of seo and isPrimary fields

[okansahin]

I am getting these notices when I use this plugin:

    "type": "DUPLICATE_FIELD",
    "message": "You cannot register duplicate fields on the same Type. The field 'seo' already exists on the type 'Product'. Make sure to give the field a unique name.",
    "field_name": "seo",
    "type_name": "Product"

And for each taxonomies:

    "type": "DUPLICATE_FIELD",
    "message": "You cannot register duplicate fields on the same Type. The field 'isPrimary' already exists on the type 'ProductToProductCategoryConnectionEdge'. Make sure to give the field a unique name.",
    "field_name": "isPrimary",
    "type_name": "ProductToProductCategoryConnectionEdge",

After I for quick lookup I see that

wp-graphql-yoast-seo/wp-graphql-yoast-seo.php

Line 315 in 56600b1

$post_types = \WPGraphQL::get_allowed_post_types();

line is already contains 'product' item. So we don't need to add it manually

wp-graphql-yoast-seo/wp-graphql-yoast-seo.php

Line 320 in 56600b1

array_push($post_types, 'product');

And also for 'Product' type

wp-graphql-yoast-seo/wp-graphql-yoast-seo.php

Lines 842 to 851 in 56600b1

	// if woocommerce is active, add seo to product
	if (class_exists('WooCommerce')) {
	register_graphql_field('Product', 'seo', [
	'type' => 'PostTypeSEO',
	'description' => __('The Yoast SEO data of the ContentNode', 'wp-graphql-yoast-seo'),
	'resolve' => function ($post, array $args, AppContext $context) {
	return wp_gql_seo_get_post_type_graphql_fields($post, $args, $context);
	},
	]);
	}

after I comment out these lines, the notices has gone and the functionality still works as expected.

I didn't examine the repo in detail, as I said, I just did a quick debug to get rid of the problem. Can the repo authors comment on this?

I can also create a PR for this.
And I think #40 is also related with

Thank you

[ashhitch]

@okansahin a PR would be very welcome.