Skip to content

Commit a434102

Browse files
RDKTV-34129: [WebKitBrowser] Use SIGHUP for suspended web process
For suspended callsing use SIGHUP to kill unresponsive WebProcess (instead of SIGFPE) to skip minidump report. In suspended state webkit browser plugin kills web process immediately on the very first unresponsiveness that produces false crash reports. Reason for change: Fix crash report on browser shutdown Test Procedure: Webapps smoke testing (launch and exit) Priority: P1 Risks: Low Signed-off-by: Andrzej Surdej <[email protected]>
1 parent df402c6 commit a434102

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

WebKitBrowser/WebKitImplementation.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3531,8 +3531,9 @@ static GSourceFuncs _handlerIntervention =
35313531
if (_unresponsiveReplyNum <= kWebProcessUnresponsiveReplyDefaultLimit) {
35323532
_unresponsiveReplyNum = kWebProcessUnresponsiveReplyDefaultLimit;
35333533
Logging::DumpSystemFiles(webprocessPID);
3534-
if (syscall(__NR_tgkill, webprocessPID, webprocessPID, SIGFPE) == -1) {
3535-
SYSLOG(Logging::Error, (_T("tgkill failed, signal=%d process=%u errno=%d (%s)"), SIGFPE, webprocessPID, errno, strerror(errno)));
3534+
// Kill with SIGHUP with no coredump/minidump
3535+
if (syscall(__NR_tgkill, webprocessPID, webprocessPID, SIGHUP) == -1) {
3536+
SYSLOG(Logging::Error, (_T("tgkill failed, signal=%d process=%u errno=%d (%s)"), SIGHUP, webprocessPID, errno, strerror(errno)));
35363537
}
35373538
} else {
35383539
DeactivateBrowser(PluginHost::IShell::FAILURE);

0 commit comments

Comments
 (0)