Update toolResult status correctly for failed bash command

Author: jguoamz

packages/core/src/codewhispererChat/controllers/chat/controller.ts

@@ -753,14 +753,19 @@ export class ChatController {
                             const output = await ToolUtils.invoke(tool, chatStream)
                             ToolUtils.validateOutput(output, tool.type)
 
+                            let status: ToolResultStatus = ToolResultStatus.SUCCESS
+                            if (output.output.success === false) {
+                                status = ToolResultStatus.ERROR
+                            }
+
                             toolResults.push({
                                 content: [
                                     output.output.kind === OutputKind.Text
                                         ? { text: output.output.content }
                                         : { json: output.output.content },
                                 ],
                                 toolUseId: toolUse.toolUseId,
-                                status: ToolResultStatus.SUCCESS,
+                                status,
                             })
                         } catch (e: any) {
                             toolResults.push({

packages/core/src/codewhispererChat/tools/executeBash.ts

@@ -311,6 +311,7 @@ export class ExecuteBash {
                 const exitStatus = result.exitCode ?? 0
                 const stdout = stdoutBuffer.join('\n')
                 const stderr = stderrBuffer.join('\n')
+                const success = exitStatus === 0 && !stderr
                 const [stdoutTrunc, stdoutSuffix] = ExecuteBash.truncateSafelyWithSuffix(
                     stdout,
                     maxBashToolResponseSize / 3
@@ -330,6 +331,7 @@ export class ExecuteBash {
                     output: {
                         kind: OutputKind.Json,
                         content: outputJson,
+                        success,
                     },
                 })
             } catch (err: any) {

packages/core/src/codewhispererChat/tools/toolShared.ts

@@ -19,6 +19,7 @@ export interface InvokeOutput {
     output: {
         kind: OutputKind
         content: string | any
+        success?: boolean
     }
 }